From owner-svn-src-all@freebsd.org Fri May 15 21:42:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A2FCC2DAEC4; Fri, 15 May 2020 21:42:28 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49P21w24mlz4Vrn; Fri, 15 May 2020 21:42:27 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 04FLgP0g088518; Fri, 15 May 2020 14:42:25 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 04FLgPA2088517; Fri, 15 May 2020 14:42:25 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202005152142.04FLgPA2088517@gndrsh.dnsmgr.net> Subject: Re: svn commit: r361066 - head/usr.sbin/jail In-Reply-To: To: Ryan Moeller Date: Fri, 15 May 2020 14:42:25 -0700 (PDT) CC: rgrimes@freebsd.org, Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 49P21w24mlz4Vrn X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.96 / 15.00]; NEURAL_HAM_MEDIUM(-0.96)[-0.964,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 21:42:28 -0000 > > On 5/15/20 4:17 PM, Rodney W. Grimes wrote: > >> On 5/15/20 3:24 PM, Rodney W. Grimes wrote: > >> > >>>> On 5/15/20 6:18 AM, Mateusz Piotrowski wrote: > >>>> > >>>>> On 5/15/20 1:38 AM, Ryan Moeller wrote: > >>>>>> Author: freqlabs > >>>>>> Date: Thu May 14 23:38:11 2020 > >>>>>> New Revision: 361066 > >>>>>> URL: https://svnweb.freebsd.org/changeset/base/361066 > >>>>>> > >>>>>> Log: > >>>>>> jail: Add exec.prepare and exec.release command hooks > >>>>>> > >>>>>> This change introduces new jail command hooks that run before and after any > >>>>>> other actions. > >>>>> Should it go into RELNOTES? > >>>> I'm not sure what all the criteria are for relnotes. > >>>> The committer's guide makes it seem like relnotes is for breaking > >>>> changes, which this is not. > >>> Please could you point at which specific language in the commiters > >>> guide makes you believe that the RELNOTES are for breaking changes? > >> Every mention of "release notes" in the document is in the context of > >> deprecating, removing, > >> or breaking things, with one exception: > > Fair, there should be a section on "new features and enhnacements" > > which is laking. However if one reads a release notes from a shipping > > version it becomes clear that the actual majority of the text in it is > > "new stuff." > > Now that I know better, how do I retcon this and other potentially > relnoteworthy enhancements I've made? :) There is a top level file in the src tree called RELNOTES that you can use to ad an entry to describing the change and the revision number. > >> > Relnotes:??? If the change is a candidate for inclusion in the > >> release notes for the next release from the branch, set to yes. > >>> RELNOTES should be for all changes that have user visible impact > >>> of any type. > >>> > >>>> -Ryan > -- Rod Grimes rgrimes@freebsd.org