Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Feb 2012 00:19:03 +0000
From:      "Philip M. Gollucci" <pgollucci@gmail.com>
To:        cvs-ports@FreeBSD.org
Subject:   Fwd: Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile ports/sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in
Message-ID:  <4F370577.3060806@p6m7g8.com>
In-Reply-To: <4F36F56B.8060304@FreeBSD.org>
References:  <4F36F4E8.8040008@FreeBSD.org> <4F36F56B.8060304@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig17A2EFA490A4AC343F48C6D3
Content-Type: multipart/mixed; boundary="------------010600030905030709060204"

This is a multi-part message in MIME format.
--------------010600030905030709060204
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

My bad Doug.  Careless ness on my part.  I'll come back through
momentarily for these rc.d files.




--------------010600030905030709060204
Content-Type: message/rfc822;
	name="Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile
	ports/sysutils/p5-MogileFS-Server/files
	mogilefsd_in mogstored_in.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename*0="Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile
	p"; 
	filename*1="orts/sysutils/p5-MogileFS-Server/files mogilefsd_in
	mogstore"; filename*2="d_in.eml"

Return-Path: <dougb@FreeBSD.org>
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by cell.p6m7g8.net (8.14.4/8.14.3) with ESMTP id q1BN8RHq044165
	for <pgollucci@p6m7g8.com>; Sat, 11 Feb 2012 23:08:27 GMT
	(envelope-from dougb@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id BE0DE1503D7
	for <pgollucci@p6m7g8.com>; Sat, 11 Feb 2012 23:08:26 +0000 (UTC)
Received: by hub.freebsd.org (Postfix)
	id AFAB51065674; Sat, 11 Feb 2012 23:08:26 +0000 (UTC)
Delivered-To: pgollucci@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id ADC82106566B;
	Sat, 11 Feb 2012 23:08:26 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-150-251.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 5EA7F1501BA;
	Sat, 11 Feb 2012 23:08:25 +0000 (UTC)
Message-ID: <4F36F4E8.8040008@FreeBSD.org>
Date: Sat, 11 Feb 2012 15:08:24 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:10.0) Gecko/20120201 Thunderbird/10.0
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
CC: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, 
	Gea-Suan Lin <gslin@gslin.org>
Subject: Re: cvs commit: ports/sysutils/p5-MogileFS-Server Makefile
	ports/sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in
References: <201202112237.q1BMbOHK097436@repoman.freebsd.org>
In-Reply-To: <201202112237.q1BMbOHK097436@repoman.freebsd.org>
X-Enigmail-Version: 1.3.5
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.9 required=4.5 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on cell.p6m7g8.net

These rc.d files are not even complete, never mind meeting the
requirements listed in
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

Additionally, in both of them _flags is used for -d and --config where
those things should be in command_args instead. In mogstored.in there's
also a literal /usr/local.

I'll leave it as an exercise for the reader to determine what (rather
important) line is missing altogether.


Doug


On 02/11/2012 14:37, Philip M. Gollucci wrote:
> pgollucci    2012-02-11 22:37:24 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     sysutils/p5-MogileFS-Server Makefile 
>   Added files:
>     sysutils/p5-MogileFS-Server/files mogilefsd.in mogstored.in 
>   Log:
>   - Add rc.d files
>   - Bump PORTREVISION
>   
>   PR:             ports/164876  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=164876
>   Submitted by:   Gea-Suan Lin <gslin@gslin.org>
>   With Hat:       perl@
>   
>   Revision  Changes    Path
>   1.23      +2 -0      ports/sysutils/p5-MogileFS-Server/Makefile
>   1.1       +19 -0     ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in (new)
>   1.1       +19 -0     ports/sysutils/p5-MogileFS-Server/files/mogstored.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/Makefile.diff?&r1=1.22&r2=1.23&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/p5-MogileFS-Server/files/mogstored.in
> 



-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/


--------------010600030905030709060204
Content-Type: message/rfc822;
	name="Re: cvs commit: ports/mail/qpopper qpopper_in.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="Re: cvs commit: ports/mail/qpopper qpopper_in.eml"

Return-Path: <dougb@FreeBSD.org>
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by cell.p6m7g8.net (8.14.4/8.14.3) with ESMTP id q1BNAd1r044211
	for <pgollucci@p6m7g8.com>; Sat, 11 Feb 2012 23:10:39 GMT
	(envelope-from dougb@FreeBSD.org)
Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 9951C14D88E
	for <pgollucci@p6m7g8.com>; Sat, 11 Feb 2012 23:10:38 +0000 (UTC)
Received: by hub.freebsd.org (Postfix)
	id 96FF81065674; Sat, 11 Feb 2012 23:10:38 +0000 (UTC)
Delivered-To: pgollucci@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 95061106566B;
	Sat, 11 Feb 2012 23:10:38 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-150-251.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 018381510C1;
	Sat, 11 Feb 2012 23:10:35 +0000 (UTC)
Message-ID: <4F36F56B.8060304@FreeBSD.org>
Date: Sat, 11 Feb 2012 15:10:35 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:10.0) Gecko/20120201 Thunderbird/10.0
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
CC: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, 
	Takefu <takefu@airport.fm>
Subject: Re: cvs commit: ports/mail/qpopper qpopper.in
References: <201202112230.q1BMU9EX096541@repoman.freebsd.org>
In-Reply-To: <201202112230.q1BMU9EX096541@repoman.freebsd.org>
X-Enigmail-Version: 1.3.5
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.9 required=4.5 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on cell.p6m7g8.net

This script also violates numerous things in
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

Please take another look at this and try again. :)


Doug


On 02/11/2012 14:30, Philip M. Gollucci wrote:
> pgollucci    2012-02-11 22:30:09 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/qpopper         qpopper.in 
>   Log:
>   - Fix qpopper.in file location
>   
>   PR:             ports/164463  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=164463
>   Submitted by:   Takefu <takefu@airport.fm>
>   Approved by:    maintainer timeout (bc979@lafn.org ; 16 days)
>   
>   Revision  Changes    Path
>   1.3       +3 -6      ports/mail/qpopper/qpopper.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/qpopper/qpopper.in.diff?&r1=1.2&r2=1.3&f=u
> 



-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/


--------------010600030905030709060204--

--------------enig17A2EFA490A4AC343F48C6D3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFPNwV5dbiP+9ubjBwRArieAJ92qn6j1DJotkXB3wNPwvzccGRJ7gCeLAGK
wJXfgIKH9AJ21IHHkd2uO7M=
=eifn
-----END PGP SIGNATURE-----

--------------enig17A2EFA490A4AC343F48C6D3--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F370577.3060806>