From owner-freebsd-current Mon Jul 8 0:21:55 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 558F937B400 for ; Mon, 8 Jul 2002 00:21:52 -0700 (PDT) Received: from mail.viasoft.com.cn (ip-167-164-97-218.anlai.com [218.97.164.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A52743E09 for ; Mon, 8 Jul 2002 00:21:48 -0700 (PDT) (envelope-from davidx@viasoft.com.cn) Received: from davidwnt (davidwnt.viasoft.com.cn [192.168.1.239]) by mail.viasoft.com.cn (8.9.3/8.9.3) with SMTP id PAA06134; Mon, 8 Jul 2002 15:37:58 +0800 Message-ID: <01d801c2264e$db1b4fe0$ef01a8c0@davidwnt> From: "David Xu" To: , "Peter Wemm" References: <20020708062855.02DE03808@overcee.wemm.org> Subject: Re: Remember my ill-fated i386 smp pmap optimizations? Date: Mon, 8 Jul 2002 15:12:43 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Gartner: Apache is vulnerable, we recommend switching back to IIS to = protect yourselves ----- Original Message -----=20 From: "Peter Wemm" To: Sent: Monday, July 08, 2002 2:28 PM Subject: Remember my ill-fated i386 smp pmap optimizations? > A few months ago, I had a bit of a disaster with some pmap = optimizations. > After committing, all hell broke loose. It was backed out completely. >=20 > I finally found the problem (diff cleaned up to highlight the = problem): >=20 > pmap_mapdev() > ... > for (tmpva =3D va; size > 0; ) { > pte =3D vtopte(tmpva); > *pte =3D pa | PG_RW | PG_V | pgeflag; > size -=3D PAGE_SIZE; > tmpva +=3D PAGE_SIZE; > - pa +=3D PAGE_SIZE; :( > } > invltlb(); >=20 > Excuse me while I go outside and shoot myself. >=20 > Cheers, > -Peter > -- > Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com > "All of this is for nothing if we don't go to the stars" - JMS/B5 sorry for a bit OT, but why are pmap_mapdev and pmap_unmapdev still = using old C language parameter style? I saw other functions in pmap using ANSI C style. David Xu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message