From nobody Sat Mar 19 21:34:11 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3C67E1A1ECF9 for ; Sat, 19 Mar 2022 21:34:27 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLZ012vmKz3w9t for ; Sat, 19 Mar 2022 21:34:25 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647725658; bh=TsS2fiqQk2yE7tE3br7CcOjqkI84AFodlLTz2SrJsvQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=QGLQmHrlrjaIYjhh6EPBFd3Ph62karSgyccK7dUBLh0vaPnbCjHnxhuoHLoktkPh0gQOJUpZuWEk4wnNj5I++p+ZQxMrYUxprnRnqKYzDpjG3NWVfdhNJJ7EmgfsOQLDFxa/qGRYfVEup1IPsZnb/LXQerq2HAaqy/9OI0k/R28oLqGy9tLY1BkKTmgb71/4lW0AzBCLkMJk0WHN/BHttZ7Sfc98mrKmwyGHA5gLbDhVEoTU10l4oKSTC3L6uDGa/SRxmC5cgoaFW+7HyfK2iZkVmcTHQdISrCvhdtMpfjRfCv+raa/NbpHaK24bv4jmn6I+/aQGpk8BIXmGABgJLA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647725658; bh=CxY2nGTCRXYzpEHHQg/Wa6KtfwZvsQVVDjJ2jpzK6Ks=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=YEeS3I/nEb/p5Be9nh70Isp0WHaRpFIG7+j9nyQYbCndygYi8QhTvTcUgZje+5gTWdIFBFBIlbUrAKl7ut0u6jfwNnMdfh0kKJsBkxbHzHjSJiBGq8Tfh7hAic7lMzYUmUUVzoRy79zw7GxkUqx+yCFzpc17EgyqgIUDMkfRnG3xdQmJwYnGxTxAdNLOQq5igFqDHy5UkDARUFxiYzvGWk8pNjee+cT9KDXNOkM3PNWLXaMIvRR6G/rDrBKpORKpDjOfJUVfvV+/04Qmw0lZtAlIeY5yCQHmdEqHu7Ld0jlPHZn28IKygtxi8G4T1aDkTBj45Wjr3+LkROhSZ6yBtg== X-YMail-OSG: KQ0Hn_gVM1kf9vS0rAMt6a4WrU.z_dwS5GI1.KYT1LXp6w6m4VBWWXf.LmXCqAp enXwXiMRov2QmyeN3Fcl3AhQUN9_FoOCeJkk3Tmvn1EumcHAXc1VVolqH25xAnuG.KgU_Xk5pjV3 uTIzoyWmLfzylpkWpUeUmXARvBseUtrV8Bb90hjDrRg9vlkEXqMLixfJPTONglGF9NM7ZpXRwbe3 hz31UM2a88SUUpzuq0e2Dk63YNRltxL1RVLDlxxfZJDpGr1b1g5JXE6qS2.LqQngUp8LLenH80lD MMLmMmu6OgSDXTMcHK7VcOx.SaefvTTS12zf9TZWpenf3IeQyQU4WTodcGNDHzD36T2zB8Osgw48 cnmqyAPUZSvwPOnSUCXfXQYj4wHnfLrXnwI6_DGT5Q.bZGlDKi2QLr2EdNj1EcY0T2Keib9pAgLb QbYq8.aduaeC0tnP64vYkwy8sw3ODVvwhnRy3U9EWDX7uqBlIeozBUkWUUOnomtE_UTgS7OiG3vX jh610fVPCuxB3XljO6Z..SzaWGUZVYjCwGcvw.R0JFTZ79LUlx1S94v0ob9hUgNarxet6L3BrVXx 3d22u.d6Gv5b8wdqbz90csiR3DD1K1CAVG_xjIXdd0k8Wx5MHPJRMGNwlvmKTsPQgWYndgg3a62M YDEPnYb8ywnY12oYMTsUpJgJIyHekdUtw7_akLJR1khLhRtqSV3_tAsyz1Ziu1dbSuwhwx1bySu. X_KAo86hd_i9rSrz5.VLh6r95AErquJNlOxE6S4pzSfvR_5675.o3lIZJEBOCTTAMoW0T0pZSigH uZCXuBdwY64e33T4L9dcJrbZFNRgenpuNxg3xnitTOdMaPZhbVh10M2ibHWv6vZSU7LEk2awyKzJ TsG4Ou9DjE6Qwos49.NMRWeE193J0S2.rN9JUqdkmYRtC7A8b0HSX_6G42GPur5i_JjGX.PcC9wb 99VgXCmr4D0PBVrVNxHSFsX.jcuRWi1CUTCH6OJIu8RL9dUkSJNPLl4knFkhFLjS569b234AcjYM XrzzCShiLr_xLFzxtGBKB8JdTSRIgLO5olW9dXJ3Ep5jnJWuq5TYDcwkeBndK_qneiU91k2sDtkS TccxHxN8xWy_WncJpa_BY2atDpILUfXIb6ZzgMqCJq7Z9hnSzVszFkOor6xDZxGXPHoQ2iG76uS1 GIcDcLdqW6ctLXMFoDxEKdxVoT4lmHKaIHPqze1RaDK3D0j5FqifgfreWvtdHPH7boRXu_.mUrdr vXM0OE0Xa513HjMoRQqPSb_yWPUDy_DHEa9Spl8FQNPcUJLKqt_DFUVmRa07daytq9xHuUsdPixx lMrUqbtG0U7uo8cbk8wKRqhEG_10GKWF1VES8oGvp9e.WsbwsTYU0nlsPo.QMh49MwA8HppT0AK. AVW_psvE_MYAoaR34VdtBz.IbEYtSQ09to3z_xamim.CnjGpZW.BPRSxjy2tUigfzvo6EsSpqBkV 8_sTFbsxb3BupWoVRX_kAqKKswklOMVZuTJgtB.N.nq_znLd6Ed2.aRaG0LnkxjGKzEwsndmebkQ QAA_KOvqlpoUVJFsiODbAuFp1PfcpARJmNep4w2jcRTElk7wsL56WUHss3rrkoL2nIQs_WVeCOkH eoGwgmKQ8ok1aJ9ImuUWlseYzHEowbPOpXO8pZ3z1tVtcGLqf2t6hXAF1q23rrQJbq0JsVpEX5_l yJ6JmAZ2iQBBJVj1UVztt.u5cNvHH1Fon9fp6eUmSBVAmTVdXOUueI8TbExpaxDAZaswjF83uBTZ ZIQHCCdkzrzOLMOA3JbuH5FDyMWgKviHQak2C2m2oj316vSGaxap3bA3O7Oy.lJ9keywsgGhATtk PUw_iba8F_nYtpCuypS.eY215YChH9Glx62yDZ2aqBare1_0EIhE28PK34dxwBdTDwiw7mCq7oo0 xgueW4dX_Bwtfi5F192aetYBqQ6LbQ5jencO06OAk70zLfVnC2_6hWdhDorbhAzaBjB6dRUfu5Cq Q6E0Jaoi.RWuYhcbFIwRBI572we255g0So4Ssy.v_htIX2mRwx.bRaVfpNwFu1E9V92O5IuD4BSh fqCQxx17TEjw.g.M0PPsMLwE1oJNfahWLInTepLRABOL2bzlJUJWwEpfNF_mwYUIz6Bo7NUmup_Q jfyyGFh0dBf5ZqV5cEjDyaQf246UY63Nc7n.fCF.87WNFVrruoRtKnEZFH6ykVzcnNBBuiNWORG6 vsaRt2IqsCE6iRZvpk1yC_ae0qdaYFXA1kYLxkowS_1ww62MP6HBe6fq2iJBlVaV.mzg99yvJmBa 3q1Tve8d3VxtXs2gP X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Sat, 19 Mar 2022 21:34:18 +0000 Received: by kubenode520.mail-prod1.omega.gq1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID cda46b52cbfc2bfc653e194eb5324e41; Sat, 19 Mar 2022 21:34:12 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 43741377b143 - main - security/openssl: Security update to 1.1.1n From: Mark Millard In-Reply-To: <4370EEAF-A332-4DEB-8E21-B24689857463@yahoo.com> Date: Sat, 19 Mar 2022 14:34:11 -0700 Cc: Thomas Zander , freebsd-ports@freebsd.org, FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: References: <2E632408-4D4E-426C-8DC7-A1024A1D328D.ref@yahoo.com> <2E632408-4D4E-426C-8DC7-A1024A1D328D@yahoo.com> <4370EEAF-A332-4DEB-8E21-B24689857463@yahoo.com> To: Mark Johnston X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4KLZ012vmKz3w9t X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=QGLQmHrl; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.68.84 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-1.57 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.99)[-0.994]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.92)[0.921]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.84:from]; MLMMJ_DEST(0.00)[freebsd-stable]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.84:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 2022-Mar-19, at 14:24, Mark Millard wrote: > On 2022-Mar-19, at 12:54, Mark Johnston wrote: >=20 >> On Sat, Mar 19, 2022 at 12:00:20PM -0700, Mark Millard wrote: >>> On 2022-Mar-19, at 11:07, Thomas Zander wrote: >>>=20 >>>> On Sat, 19 Mar 2022 at 18:32, Mark Millard = wrote: >>>>> May be report to Mark J. how to run the same test builds >>>>> that failed for -p8 but worked for -p7? >>>>=20 >>>> Sure, good point. >>>> A build that reliably causes broken packages on p8 but not on p7 = for >>>> me is running: >>>>=20 >>>> poudriere testport -o multimedia/mplayer -j <13.0-amd64-jail here> >>>>=20 >>>> This caused the broken png and python packages when they were built = as >>>> dependencies. >>>> In poudriere.conf I set this: >>>> DISTFILES_CACHE=3D/vcache/distfiles >>>> CCACHE_DIR=3D/vcache/ccache >>>> ALLOW_MAKE_JOBS=3Dyes >>>>=20 >>>> The ALLOW_MAKE_JOBS should increase the number of parallel IO >>>> operations in-flight on the pool, maybe this increases the = likelihood >>>> of triggering the issue? >>>> The DISTFILES_CACHE and CCACHE_DIR are in the same zfs pool as >>>> /poudriere, not sure if this is relevant. >>>> The zfs pool is a single disk, no raid, mirror or anything fancy. >>>=20 >>> On a ThreadRipper 1950X, PCIe Optane storage, 128 GiBytes of >>> RAM, I've used bectl to boot the 13.0_RELEASE-p8 environment >>> and have started: >>>=20 >>> poudriere testport -o multimedia/mplayer -j13_0R-amd64-bulk_a >>>=20 >>> where the jail had nothing built in it at the start. So: >>>=20 >>> [00:00:08] Building 271 packages using up to 32 builders >>>=20 >>> The primary difference is that I've never used ccache and >>> did not try to do so here. The "zfs pool is a single disk, >>> no raid, mirror or anything fancy" is accurate, as is the >>> use of ALLOW_MAKE_JOBS=3D . >>>=20 >>> That did not take long . . . >>>=20 >>> It proves that ccache is not required. Also some files >>> seem to get only small blocks of zero-bytes, others >>> large ones. But I've not checked for the null characters >>> being at the end instead of earlier in the file. >>=20 >> I still am not able to reproduce it. I think it's indeed a = concurrency >> problem, and I found a possible culprit. Mark or Thomas, if you're = able >> to build a new kernel from the releng/13.0 branch and test it, could = you >> please try this patch? >>=20 >=20 > Sure. (I build ports in a way that allows large load > averages relative to the hardware-thread count. I also > have a lot of swap configured. I avoid significant use > of tmpfs.) >=20 >> diff --git a/sys/contrib/openzfs/module/zfs/dnode.c = b/sys/contrib/openzfs/module/zfs/dnode.c >> index 8592c5f8c3a9..b69ba68ec780 100644 >> --- a/sys/contrib/openzfs/module/zfs/dnode.c >> +++ b/sys/contrib/openzfs/module/zfs/dnode.c >> @@ -1661,7 +1661,7 @@ dnode_is_dirty(dnode_t *dn) >> mutex_enter(&dn->dn_mtx); >>=20 >> for (int i =3D 0; i < TXG_SIZE; i++) { >> - if (list_head(&dn->dn_dirty_records[i]) !=3D NULL) { >> + if (multilist_link_active(&dn->dn_dirty_link[i])) { >> mutex_exit(&dn->dn_mtx); >> return (B_TRUE); >> } >>=20 >=20 > Change made. > Rebuilt. > Reinstalled. > Rebooted into the 13_0R-amd64 be area. > Bulk build started. > Bulk build completed. > (Took longer because I let it run to completion.) >=20 > No explicit reports of null characters. The same 2 ports that > failed before, not reporting zero-byte issues, failed again. > Likely independent issues: >=20 > [00:28:28] Failed ports: security/libgcrypt:build = print/freetype2:package These are what happens for WITH_DEBUG=3D style builds. Turns out that the *make.conf files from my last bulk -a experiment were still in place and were causing WITH_DEBUG=3D builds. (Not my normal context.) I'll disable that and rerun the bulk from scratch. > Overall it skipped something like 54 ports. >=20 > libgcrypt-1.9.4.log . . . >=20 > --- basic.o --- > basic.c:315:16: error: inline assembly requires more registers than = available > asm volatile("movdqu %[data0], %%xmm0\n" > ^ > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > --- mpitests --- > . . . > --- basic.o --- > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > basic.c:315:16: error: inline assembly requires more registers than = available > fatal error: too many errors emitted, stopping now [-ferror-limit=3D] >=20 >=20 > freetype2-2.11.1.log . . . >=20 > =3D=3D=3D> Building package for freetype2-2.11.1 > pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= :No such file or directory > pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6:No such file or directory > pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6.18.1:No such file or directory > *** Error code 1 >=20 >=20 > I think this indicates that your fix works. >=20 >=20 >=20 > For reference: >=20 > # ~/fbsd-based-on-what-commit.sh -C /usr/ports/ > branch: main > merge-base: 0c4fe38bd1b9e3ede128751db17a8a2d1bdffe6f > merge-base: CommitDate: 2022-03-15 16:15:33 +0000 > 0c4fe38bd1b9 (HEAD -> main, freebsd/main, freebsd/HEAD) misc/urh: = Update 2.9.2 -> 2.9.3 > n577366 (--first-parent --count for merge-base) >=20 >=20 =3D=3D=3D Mark Millard marklmi at yahoo.com