From owner-svn-src-all@FreeBSD.ORG Sat Jul 26 14:43:57 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D4ECA55E; Sat, 26 Jul 2014 14:43:57 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A5E312219; Sat, 26 Jul 2014 14:43:57 +0000 (UTC) Received: from c-50-155-136-3.hsd1.co.comcast.net ([50.155.136.3] helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1XB3CW-000KpC-2k; Sat, 26 Jul 2014 14:43:56 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s6QEhtZi003474; Sat, 26 Jul 2014 08:43:55 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.155.136.3 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18eTzlsjgwWOTCPUIKVltde X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r269112 - head/sys/boot/arm/at91/boot2 From: Ian Lepore To: Benjamin Kaduk In-Reply-To: References: <201407260409.s6Q49i20065578@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Sat, 26 Jul 2014 08:43:54 -0600 Message-ID: <1406385834.56408.24.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2014 14:43:57 -0000 On Sat, 2014-07-26 at 10:33 -0400, Benjamin Kaduk wrote: > On Sat, Jul 26, 2014 at 12:09 AM, Ian Lepore wrote: > > > Author: ian > > Date: Sat Jul 26 04:09:43 2014 > > New Revision: 269112 > > URL: http://svnweb.freebsd.org/changeset/base/269112 > > > > Log: > > The 'flags' variable is conflicting with some inline code in a header > > file > > ("variable flags shadows a global..."), just rename this variable to > > wish away the problem. > > > > Not trying to pick on you, but we have lots of places where we get > "variable shadows a global..." -- we have a global variable 'buf' in > the kernel namespace, for one :) > Do we think it's a good use of our time to try and get this to zero > instances? > > -Ben It was breakage I had to fix to get it to build so I could move ahead to the changes I was actually trying to make. (We use this stuff at $work; it has actually been disconnected from the build in freebsd for quite a while and has bitrotted. My goal is basically diff reduction between our repo at work and the base, and closing a 3 year old PR.) I guess boot2 must build with -Werror or something -- I didn't even think about changing the flags, I just did the same thing we did at work a couple years ago. -- Ian