From owner-cvs-all@FreeBSD.ORG Mon Jan 22 01:06:30 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2AB4416A401; Mon, 22 Jan 2007 01:06:30 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id EDC8F13C471; Mon, 22 Jan 2007 01:06:29 +0000 (UTC) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l0M16HhU015102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 21 Jan 2007 17:06:19 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <45B40E09.5090907@errno.com> Date: Sun, 21 Jan 2007 17:06:17 -0800 From: Sam Leffler User-Agent: Thunderbird 1.5.0.8 (X11/20061115) MIME-Version: 1.0 To: Marius Strobl References: <200701200056.l0K0uoVU042909@repoman.freebsd.org> <45B3C6FC.5090107@errno.com> <20070121204929.GA63345@alchemy.franken.de> In-Reply-To: <20070121204929.GA63345@alchemy.franken.de> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.8 ifmedia.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 01:06:30 -0000 Marius Strobl wrote: > On Sun, Jan 21, 2007 at 12:03:08PM -0800, Sam Leffler wrote: >> Marius Strobl wrote: >>> marius 2007-01-20 00:56:49 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sbin/ifconfig ifconfig.8 ifmedia.c >>> Log: >>> - Display the media instance numbers and allow the user to set the active >>> one. This is based on NetBSD but unlike NetBSD this implementation prints >>> the instance number for all media instances and doesn't skip it for the >>> first one as I don't see a reason to suppress it except for the vague >>> reason to preserve the output for single-instance configurations. >>> - Fix some whitespace nits. >> This overflows 80 cols for wireless devices. > > I'm sorry about that. > >> I suspect the information >> is meaningless to most folks and can be safely hidden under the -v option. >> >> Alternatively we can take an axe to the media reporting for 802.11 >> devices. It's pretty lame in it's present form. >> > > Well, I think that the active media instance is equally interesting > to the media type so I'd opt for the latter but I'm certainly biased > as I've a bunch of different NICs that use more than one PHY... > For 802.11 devices does the listing of the supported media also > overflow 80 cols or is just the line regarding the status of the > active media? > Would it still overflow when shortening "instance" to "inst"? > I have many nics; none w/ multiple PHY's. I suggest you are in the minority and printing it only when non-zero or verbose would resolve this. Sam