From owner-freebsd-current@FreeBSD.ORG Mon Feb 4 16:55:59 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B46AE16A418; Mon, 4 Feb 2008 16:55:59 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 6E7CF13C46A; Mon, 4 Feb 2008 16:55:59 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.2/8.14.2/NETPLEX) with ESMTP id m14GtqUc023021; Mon, 4 Feb 2008 11:55:52 -0500 (EST) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-4.0 (mail.netplex.net [204.213.176.10]); Mon, 04 Feb 2008 11:55:53 -0500 (EST) Date: Mon, 4 Feb 2008 11:55:52 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= In-Reply-To: <86zlugeqaz.fsf@ds4.des.no> Message-ID: References: <861w7um5o5.fsf@ds4.des.no> <20080203162918.GK57756@deviant.kiev.zoral.com.ua> <20080203121112.426a8c25@kan.dnsalias.net> <86zlugeqaz.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: MULTIPART/Mixed; BOUNDARY="=-=-=" Content-ID: Cc: Kostik Belousov , threads@freebsd.org, Peter Wemm , current@freebsd.org Subject: Re: Symbol versioning errors in libthr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 16:55:59 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --=-=-= Content-Type: TEXT/PLAIN; CHARSET=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Mon, 4 Feb 2008, Dag-Erling Sm=C3=B8rgrav wrote: > I've attached my proposed patch. Please yell if there's anything wrong > with it. I question the bumping of FBSDprivate to 1.1. FBSDprivate is special, it is only for use in our base system, and our supported method of updating our system is buildworkd/buildkernel - so any changes to FBSDprivate should be unnoticed. Initially, I did not add a version number to FBSDprivate, but did at the end after seeing that Solaris had versioned private as well. But, at least with Solaris 8, they only have SUNWprivate 1.1 and 1.2, whereas they have many public versions (SUNW_0.7 - SUNW_1.20.4). They must have old applications that were part of their base, but are no longer supported on more recent releases, so had to bump the private namespace. Also, if you look at libc/Versions.def, you will see that there is no FBSDprivate_1.1. I think your patch is fine as long as you use only FBSDprivate_1.0. --=20 DE --=-=-=--