From owner-cvs-all  Fri Jul 12  1:47:13 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 17D3437B400; Fri, 12 Jul 2002 01:47:09 -0700 (PDT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8A4C043E31; Fri, 12 Jul 2002 01:47:08 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g6C8kxwr013248;
	Fri, 12 Jul 2002 01:47:03 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Message-Id: <200207120847.g6C8kxwr013248@gw.catspoiler.org>
Date: Fri, 12 Jul 2002 01:46:59 -0700 (PDT)
From: Don Lewis <dl-freebsd@catspoiler.org>
Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c
To: hsu@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <0GZ4004U3MZCIJ@mta5.snfc21.pbi.net>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 12 Jul, Jeffrey Hsu wrote:
>   > Lock inp while we're accessing it.
> 
> Here's a rhetorical question:  why?  That inp was purposely left unlocked.

Comparing udp_getcred() with tcp_getcred(), the missing lock looked like
an oversight.  Isn't it possible for inp->inp_socket to get modified by
another thread in either case unless inp is locked?


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message