From owner-cvs-src@FreeBSD.ORG Tue Dec 19 22:55:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5EEE616A416; Tue, 19 Dec 2006 22:55:19 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8D6C43CAE; Tue, 19 Dec 2006 22:55:18 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kBJMqCPW057909; Tue, 19 Dec 2006 15:52:13 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 19 Dec 2006 15:53:15 -0700 (MST) Message-Id: <20061219.155315.756909997.imp@bsdimp.com> To: mb@imp.ch From: "M. Warner Losh" In-Reply-To: <20061219194842.M53548@godot.imp.ch> References: <20061219181505.L53548@godot.imp.ch> <4588251F.3040206@errno.com> <20061219194842.M53548@godot.imp.ch> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Tue, 19 Dec 2006 15:52:14 -0700 (MST) Cc: sam@errno.com, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2006 22:55:19 -0000 In message: <20061219194842.M53548@godot.imp.ch> Martin Blapp writes: : : Hi, : : > That is not what I was asking for. You said "there are races" but : > didn't identify them. It would be helpful to know what these races are : > so someone other than you doesn't need to guess why you made this change. : : The reason for this is currently unknown (it shouldn't happen, tegges patch : should work) and I (and bde) didn't had the time to look into it. As promised : I'll look why it happens and then I'll add a comment at the needed places. If the races are unknown, how do you know that you've really fixed things rather than introducing a random frob that does nothing but confuse people who come along later? Warner