Date: Sat, 16 Feb 2019 20:46:31 +0000 From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 234671] clang faults while compiling new GlusterFS source code Message-ID: <bug-234671-29464-3loLmbgpVa@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234671-29464@https.bugs.freebsd.org/bugzilla/> References: <bug-234671-29464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234671 Dimitry Andric <dim@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |In Progress --- Comment #6 from Dimitry Andric <dim@FreeBSD.org> --- After merging the upstream fixes, clang won't crash anymore with a fatal er= ror. It still will refuse to compile the glfs.c file though, now with: error: versioned symbol glfs_upcall_register@@GFAPI_3.13.0 must be defined error: versioned symbol glfs_upcall_unregister@@GFAPI_3.13.0 must be defined 2 errors generated. Indeed, this is an error in the code, which seems to have been fixed in this upstream commit (together with a lot of other symbol breakage): https://github.com/gluster/glusterfs/commit/b4ce5e090dee2afc9ed0c86456a54f7= 6a2bb6563 Can you try applying that, or at least parts of it? Alternatively, a minim= al fix is: --- a/glfs.c 2019-01-10 08:57:50.000000000 +0100 +++ b/glfs.c 2019-02-16 21:45:03.999966000 +0100 @@ -48952,7 +48952,7 @@ GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_sysrq, 3.10.0); int -glfs_upcall_register (struct glfs *fs, uint32_t event_list, +pub_glfs_upcall_register (struct glfs *fs, uint32_t event_list, glfs_upcall_cbk cbk, void *data) { int ret =3D 0; @@ -49003,7 +49003,7 @@ } GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_upcall_register, 3.13.0); -int glfs_upcall_unregister (struct glfs *fs, uint32_t event_list) +int pub_glfs_upcall_unregister (struct glfs *fs, uint32_t event_list) { int ret =3D 0; /* list of supported upcall events */ --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234671-29464-3loLmbgpVa>