From owner-cvs-all Mon Feb 4 3:52:55 2002 Delivered-To: cvs-all@freebsd.org Received: from mongrel.pacific.net.au (mongrel.pacific.net.au [61.8.0.107]) by hub.freebsd.org (Postfix) with ESMTP id 43F1D37B421; Mon, 4 Feb 2002 03:52:50 -0800 (PST) Received: from dungeon.home (ppp67.dyn248.pacific.net.au [203.143.248.67]) by mongrel.pacific.net.au (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id WAA16733; Mon, 4 Feb 2002 22:44:26 +1100 X-Authentication-Warning: mongrel.pacific.net.au: Host ppp67.dyn248.pacific.net.au [203.143.248.67] claimed to be dungeon.home Received: from dungeon.home (localhost [127.0.0.1]) by dungeon.home (8.11.3/8.11.1) with ESMTP id g14BvhC06852; Mon, 4 Feb 2002 21:57:43 +1000 (EST) (envelope-from mckay) Message-Id: <200202041157.g14BvhC06852@dungeon.home> To: Ian Dowse Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, mckay@thehub.com.au Subject: Re: cvs commit: src/usr.sbin/ctm/ctm_rmail ctm_rmail.c References: <200201222254.g0MMsqg19740@freefall.freebsd.org> In-Reply-To: <200201222254.g0MMsqg19740@freefall.freebsd.org> from Ian Dowse at "Tue, 22 Jan 2002 22:54:52 +0000" Date: Mon, 04 Feb 2002 21:57:43 +1000 From: Stephen McKay Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tuesday, 22nd January 2002, Ian Dowse wrote: >iedowse 2002/01/22 14:54:52 PST > > Modified files: > usr.sbin/ctm/ctm_rmail ctm_rmail.c > Log: > The mode of files created by ctm_rmail was always 0600, even if the > umask was less restrictive. This was caused by the use of mkstemp() > which internally passes a mode of 0600 to open(). Fix this by > explicitly chmod'ing the files to (0666 & ~umask). This is pretty silly. The right way to fix this is to revert back to using mktemp(). Probably revert the whole 1.14 delta. I'll put this on my TODO list. Stephen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message