Date: Tue, 2 Jul 2019 10:50:12 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Greg Lewis <glewis@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 Message-ID: <20190702085012.GB17073@KGPE-D16> In-Reply-To: <20190702083515.seykaqqjd77zyyr2@ivaldir.net> References: <201907012118.x61LIIQr011692@repo.freebsd.org> <20190702072450.GA17073@KGPE-D16> <20190702082607.GA45590@FreeBSD.org> <20190702083515.seykaqqjd77zyyr2@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--SkvwRMAIpAhPCcCJ
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
No, when powerpc64 works with clang (which will by the way happen this month in head), openjdk11 should still build, because USE_GCC=yes is in .if ${COMPILER_TYPE} == gcc block.
On 19-07-02 10:35:15, Baptiste Daroussin wrote:
>On Tue, Jul 02, 2019 at 08:26:08AM +0000, Alexey Dokuchaev wrote:
>> On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote:
>> > Why not use USES=compiler:c11 instead of setting manually USE_GCC=yes?
>>
>> Technically they're semantically not the same; while pulling C11-capable
>> compiler might fix the problem, you're still telling the reader that you're
>> pulling C11-capable compiler, while USE_GCC means that you want GCC, devoid
>> of particular reasons.
>>
>> In practice, compiler:c11 often used as compiler:modern. I'd welcome this
>> spelling: it would actually make things more clear because now people often
>> abuse compiler:c11 or (even worse) compiler:c++11-lang for 98/99 code which
>> gcc-4.2 cannot eat, or because one of the dependencies requires new compiler
>> (majority of cases).
>>
>> ./danfe
>>
>> P.S. Sorry for lack of context due to prior top-posting.
>>
>
>Actually the majority of addition of compiler:c11 are wrong (from the one I have
>been able to check) and a simple USE_CSTD=c99 would have fix the build with
>gcc-4.2. It would be really nice to stop blindy using compiler:c11 ;)
>
>actually USE_GCC in this case is wrong as well, because if one day powerpc64
>works with llvm/clang, then this will be broken. One has to identify what is
>really making it inconcompatible with gcc-4.2, without checking it should be
>mostly related to c++ (as the jvm is mostly written in c++) and if it is because
>it uses "modern" c++ then any of the compiler:c++* is supposed to be the proper
>thing to add.
>
>Best regards,
>Bapt
--SkvwRMAIpAhPCcCJ
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl0bGsQACgkQelmbhSCD
nJ0nexAAxBTydjcegFXxlZULT8AH1c0wLQS1PyDxcjlSYQefrlOQNqbKoavnWMxL
7priVkTWgf0gKlIWQuJz3ZuJYMoDjks6ENFFDlKNPSjgkNqsHt8I2GX7O+oCi413
aFPjrrtCKzVbWWks5OCSbNPzq/QGg70XXQUWn513B635yy4+pSPxxmMWyd3GAXZ1
Ndf9+kY/wEqpZtDPOD8amr/+vaNJd4IbPUg380DfAHiPnHkmxYCEn1uuALEIkmLJ
1kPR5ds/opLj+mtXk96WKQ8SvILvR5M2cnx7lYPvgKde5RLViVhASlHbjNpY+S1l
hdGecy9l8dBdYJCOPtvt/fZ4JV5+fPOn7PS1M843uk1DHxG/CiGxMymbQS4m3/52
aRXnC4del4qMQp9Azyds5no4jvBj1zJr+wU/wKTzFQzl4hWvedWKWUdK7VvJHTsa
563O6v8xJI+9xdjipcO4OduGoKX2gejcvkGFVlgCOT4eZ1BtxU18IPmYM7AayuPd
4gdiQ47eS+8Uk6eFzGCNFSM0WzBTA7PBsuF3srreTMuoAwlcnnsvyGt3EwUIL543
ZWry5ZEFAvSfutM3mk0CKjouvHhXY3IWxaT/YcTbe4VG6+nkBB0gJL19OaLrl+Po
Yln6DLr5xxVgCPNTmm55CPo3RMKCNCArvykKKaWYP3+TQo8zZAI=
=LesH
-----END PGP SIGNATURE-----
--SkvwRMAIpAhPCcCJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190702085012.GB17073>