From owner-dev-commits-ports-main@freebsd.org Wed Apr 14 08:20:39 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9F5E5CEB0E; Wed, 14 Apr 2021 08:20:39 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FKwQb4DXgz4hs0; Wed, 14 Apr 2021 08:20:39 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 52E3C53AD; Wed, 14 Apr 2021 08:20:39 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:0:1ea9:463d:9962:36c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id EE29F942D80; Wed, 14 Apr 2021 08:20:36 +0000 (UTC) Date: Wed, 14 Apr 2021 10:20:35 +0200 From: Mathieu Arnold To: Kevin Bowling Cc: Jochen Neumeister , Kevin Bowling , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3d55eddff7e1 - main - www/xshttpd*: Remove from tree Message-ID: <20210414082035.jvdhqjqye2xqwote@aching.in.mat.cc> References: <202104121911.13CJB3Xs079950@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="op72q2ofut7tpq73" Content-Disposition: inline In-Reply-To: X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2021 08:20:39 -0000 --op72q2ofut7tpq73 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Apr 13, 2021 at 09:21:49AM -0700, Kevin Bowling wrote: > Take a look in the referened PR 254750, the MOVED file also contains > details. The gist is, it probably shouldn't have been brought back > into the tree as it is abandoned, but was and then remained broken for > over two years. No. The commit message MUST state first and foremost the reason (aka the why) behind the commit. The what can be seen by looking at the diff, the what SHOULD be explained (and I say explained, not just translate the diff to english) in the commit message if the reason behind a bit of change is not clearly explained by the why. Extra information if available in a PR for example MAY (note, I said MAY, not SHOULD or MUST) be left out and an interested party can go look the PR or whatever other reference was made available in the commit message. In this example, the commit message could have started a bit like this: www/xshttpd*: Remove abondonware & unfetchable And then there may have been another paragraph expanding on the reason behind the removal, for example something like this: No new upstream release for the past 10 years, distfile not fetchable, and website returns 404. > On Mon, Apr 12, 2021 at 12:23 PM Jochen Neumeister w= rote: > > > > > > Am 12.04.21 um 21:11 schrieb Kevin Bowling: > > > The branch main has been updated by kbowling: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D3d55eddff7e1761575e2= 9e946d384ad42eca3067 > > > > > > commit 3d55eddff7e1761575e29e946d384ad42eca3067 > > > Author: Kevin Bowling > > > AuthorDate: 2021-04-12 19:08:44 +0000 > > > Commit: Kevin Bowling > > > CommitDate: 2021-04-12 19:10:53 +0000 > > > > > > www/xshttpd*: Remove from tree > > > > > > PR: 254750 > > > Reported by: daniel.engberg.lists@pyret.net > > > > > > Hi, > > > > it would be good if you also wrote why the port was removed. > > > > > > Greetings > > Jochen > > > > > > > --- > > > MOVED | 2 + > > > www/Makefile | 2 - > > > www/xshttpd-devel/Makefile | 64 --------------------- > > > www/xshttpd-devel/distinfo | 2 - > > > www/xshttpd-devel/files/patch-src_extra.c | 34 ----------- > > > www/xshttpd-devel/files/patch-src_httpd.c | 10 ---- > > > www/xshttpd-devel/files/patch-src_ssl.c | 32 ----------- > > > www/xshttpd-devel/files/xshttpd.in | 28 --------- > > > www/xshttpd-devel/pkg-descr | 9 --- > > > www/xshttpd-devel/pkg-plist | 94 --------------------= ----------- > > > www/xshttpd/Makefile | 66 --------------------= -- > > > www/xshttpd/distinfo | 2 - > > > www/xshttpd/files/patch-src_httpd.c | 11 ---- > > > www/xshttpd/files/patch-src_ssl.c | 14 ----- > > > www/xshttpd/files/xshttpd.in | 28 --------- > > > www/xshttpd/pkg-descr | 23 -------- > > > www/xshttpd/pkg-plist | 84 --------------------= ------- > > > 17 files changed, 2 insertions(+), 503 deletions(-) > > > > > (snip) >=20 --=20 Mathieu Arnold --op72q2ofut7tpq73 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmB2pc9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgK2RBAAlcYxJLiaz5biblyeXg5c9XVYs1q7E49VwKaXsRVdhPs1sUI4EmFr7rfn PDHi6y/k3AEtbGSa535ZQiKHFAwtM2jMAFWxcNvJWLlW8kq4wH5C7GFWkAW/ffEg RpcDseF1oQ/vu8HMDuvIMrym77PWbj8I2czQdC0Jtpcl+hxWFKPW6+TWkOTLJQuq 9caS9OM6tiVUPJXb9ekK5hrF9qMBT52BGiFbr0iRZe2JTrDjCwIoy3vdLQIXgj9c 1lDeVwz6B75DtXlzW1teletjvN7LS9uU7/sNJ31EaVYwLNo2sZmC0CsEd+lhd8yh mhkTfAycm+O2avy3Y7m0UJAmuoAqMX5Cl5G7dYbNIrHxcU9OwrJdHvYP+pZDNV6S UHYcN5Z9V36j9MOVe0hP9BLIgeS14yE8EjAE8/9Jwty5V/Z20PmfDDfynpr9jkM0 6LU+bRGFf6SpHfON7XHCgHipYv/GsKZH0lfcTLutlSp7dJdWfA+0gsmRG2bt1rYG gT4EirSIGKE307kZ3xb2YX3dSy2i9XPr4qscasbgpYzFCYKPmmOoiTvby9/G3Qjx UAvp6H9hlJEtDcOvtxuze8slbVjpUp0YxUjs4MmXFCsPisYkWNtOElBNz1w47MO9 piK9KY4SW2wg7giR73udArSqh6Ntha2+qj2rPlmvrc3mqCtTu6o= =2jKJ -----END PGP SIGNATURE----- --op72q2ofut7tpq73--