From owner-svn-ports-head@freebsd.org Tue Jan 8 21:12:12 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33887148B467; Tue, 8 Jan 2019 21:12:12 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF396800BD; Tue, 8 Jan 2019 21:12:11 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3096227565; Tue, 8 Jan 2019 16:12:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 08 Jan 2019 16:12:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=weq65p 3aaxRPGuhvRkl2gkVmY67j65KJoECuIzRnx6o=; b=hUc1JdiuPgi+pFgF2RxX19 Dadvvp9XLr2NlzF065NWJ2ix6lKlnWvOc8I89oRHOfzVsOT4kzkRNfCNMKUMY0q0 qTj1CDQ0GRQUyVgkiU5nmoR1jGmpPj39vyjPXKTtnjgtNAX5J73CN1ulFgkQY5Ci MgDsztemF0NNue/x2g2C7rf+PNOsnsiBNVmNcmAXGnqznZGIxCGRFM0u16tUDVAn pJdrHrL6cjDadu9DidFPd5skOxG+vRXmV4LuUEtXTmgocvW/KR4042jLzp3/SGRE Lv+lRTQSvOElrG7Hvc/pvt1K3YSi3COReEzZ9PbdMsV7U08FQ4tpBUWeyJNeGjDg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrvdelgddugeeiucdltddurdegtdekrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehgtderredtredvnecuhfhrohhmpefvohgs ihgrshcumfhorhhtkhgrmhhpuceothhosghikhesfhhrvggvsghsugdrohhrgheqnecukf hppeefuddrudejrddvhedurddvudenucfrrghrrghmpehmrghilhhfrhhomhepthhosghi khesfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from urd.tobik.me (ip1f11fb15.dynamic.kabel-deutschland.de [31.17.251.21]) by mail.messagingengine.com (Postfix) with ESMTPA id 0CC7810087; Tue, 8 Jan 2019 16:12:09 -0500 (EST) Date: Tue, 8 Jan 2019 22:12:08 +0100 From: Tobias Kortkamp To: Sean Bruno Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <20190108211207.GA71800@urd.tobik.me> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: CF396800BD X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 21:12:12 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 08, 2019 at 11:44:57AM -0700, Sean Bruno wrote: >=20 >=20 > On 1/8/19 10:23 AM, Sean Bruno wrote: > >=20 > >=20 > > On 1/3/19 4:23 PM, Tobias Kortkamp wrote: > >>> > >>> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: > >>>>> +USE_QT=3D buildtools \ > >>>> Does clementine-player, a music player, really need qt5-buildtools > >>>> at runtime or should this be buildtools_build instead? > >>>> > >>>>> + concurrent \ > >>>>> + core \ > >>>>> dbus \ > >>>>> gui \ > >>>>> imageformats \ > >>>>> - qmake_build \ > >>>>> linguist_build \ > >>>>> - moc_build \ > >>>>> network \ > >>>>> opengl \ > >>>>> - qtestlib \ > >>>>> - rcc_build \ > >>>>> + qmake_build \ > >>>>> + testlib \ > >>>> Same here. Does it really need qt5-testlib at runtime? > >>>> > >>> Probably not? > >>> > >>> sean > >>> > >> So I guess they are not needed at runtime. Will you change them > >> to build dependencies? > >=20 > > Yeah, I'll look at it today. Thanks! > >=20 > > sean > >=20 >=20 >=20 > Something like this will solve this runtime/buildtime depend issue? > Obviously, I'll buildtime/runtime test it before commit. >=20 > Index: audio/clementine-player/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- audio/clementine-player/Makefile (revision 489727) > +++ audio/clementine-player/Makefile (working copy) > @@ -41,7 +41,7 @@ > USE_GL=3D gl glew glu > USE_XORG=3D x11 >=20 > -USE_QT=3D buildtools \ > +USE_QT=3D buildtools_build \ > concurrent \ > core \ > dbus \ > @@ -51,7 +51,7 @@ > network \ > opengl \ > qmake_build \ > - testlib \ > + testlib_build \ > sql \ > widgets \ > x11extras \ >=20 Yes, thanks. This looks fine to me. --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlw1EiVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2GbJwgAsO214aA2eP8ub+5BbZ+S3BHLYr1CPNxCCG+KPhh1ekIBdkAPqEpvVwv8 K4FfZPHsjVqbaQeZGIfBHhPbHL4Jkhs4gYecGVBjkvp2Lea4UT1ZAmoYtKFKK4ZF nfj7IDiCdZlecUiJqXigAIxRf6HUq5iLKaI+As9uQE27teAtwQXjZVp1e22UHg5K UqRrO1B/fzV7KZ1NntSVJJexyZrp9xe/xhdTm9MRzES2+fdq7E8ytzlkAjZZx6nL Pmw4IZg2u6Ncvtf/f5rY2Hc6E3jZj4rPhz3EYoexKXXxmjwB1PZbPu3jLNyF/pNW qiTpYgy3RSDPdrRvbW/LtM9GTnNrVw== =E8Fr -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--