From owner-svn-ports-head@freebsd.org Thu Oct 19 18:57:29 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C81FE44609; Thu, 19 Oct 2017 18:57:29 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay104.isp.belgacom.be (mailrelay104.isp.belgacom.be [195.238.20.131]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A11B774AD; Thu, 19 Oct 2017 18:57:27 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3A7955gBMICv/l8YWoBPUl6mtUPXoX/o7sNwtQ0KIM?= =?us-ascii?q?zox0K/z6pMbcNUDSrc9gkEXOFd2CrakV26yO6+jJYi8p2d65qncMcZhBBVcuqP?= =?us-ascii?q?49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6?= =?us-ascii?q?JvjvGo7Vks+7y/2+94fdbghMhzexe69+IAmrpgjNq8cahpdvJLwswRXTuHtIfO?= =?us-ascii?q?pWxWJsJV2Nmhv3+9m98p1+/SlOovwt78FPX7n0cKQ+VrxYES8pM3sp683xtBnM?= =?us-ascii?q?VhWA630BWWgLiBVIAgzF7BbnXpfttybxq+Rw1DWGMcDwULs5Qiqp4bt1RxD0iS?= =?us-ascii?q?cHLz85/3/Risxsl6JQvRatqwViz4LIfI2ZMfxzdb7fc9wHX2pMRshfWSxfDI2h?= =?us-ascii?q?bIUADeQBMulEoIfyvFYOsRmzCRWwCO/z1jNEmHn71rA63eQ7FgHG2RQtEcwPsH?= =?us-ascii?q?TWqNX+KbkfUeeyzKnT0zrDaulZ2THm6IPVdR0hvfCMXbB0ccfKyUcvDR3KgUuN?= =?us-ascii?q?pIL4MT2ZzOMNs3KU7+d5U++klm0pqxlprzWs2ssgkJfFip4Ixlze+ih0zpw5KN?= =?us-ascii?q?65RUN9fNWqCoFftzuAOItzWs4iRmZotzskxbAeop67eTQKyIwgxx7Cd/yLa4iI?= =?us-ascii?q?7QznVOaWOTp4h2hqeLa+hxa370eg0Or8WtOo0FZLrCpFlsPAuWwK1xzU8ciIVP?= =?us-ascii?q?598V2n2TaUzQzT7ftEIU8smaraLZ4u3KIwm4IQvEjfBCP6hln6gLKMekgr9OWk?= =?us-ascii?q?8efqb7T+qp+ZLYB0iwX+Mqo0msy4BOQ1KhQOX2mZ+eS4z7Dj81f5T6tUgfItia?= =?us-ascii?q?nWrYrWJcMBpq62GwNVyJos6w6jDze619QVhWEHLFVfeBKblIjlIk3BIPf9Dfe6?= =?us-ascii?q?glSsjCtryO7cPr36GZjNIGLDn6n/crlm8E5T1RA/zddF55JbErsBOu78WlfttN?= =?us-ascii?q?zECR80Kxe0w/jhCNlkzoMeXniPArOCMK/Lq1CI4uYvLvKCZI8PpjnyNeMq5+Xz?= =?us-ascii?q?gnMjnl8dZ6ap14MNaH+kBvRmP1mZYX30j9caH2YKvw4+TOjxiFCZXz5TfWi9UL?= =?us-ascii?q?wn6TEgFY2qF4DDRpqigLaZxie0AoVWZnxaClCLCXrobJuEW/EVZCKKJc9hiCAE?= =?us-ascii?q?VaO4R48hyx6hrhL1xqFpLurO5CIXq4ns1MNo6OHJkhEy7zN0BdyH026RV2F0gn?= =?us-ascii?q?8IRzgu0aB9ukNy1FaD3rR4g/FDG9xT/e1GXRkhOp7H0uN2EdfyWhjOfoTBdFHz?= =?us-ascii?q?YNygSRs8T9kxi4sMaUt8ENWKoArO0gCRL/kSjbPdV7Iu9aeJ43nzI45WzHHd2a?= =?us-ascii?q?woiUJuFtdON2mOqLRy+iLoK8jOiUrPxPXiTrgVwCOYrDTL9mGJpkwNFVcoCag?= =?us-ascii?q?=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DKCgCb9OhZ/1YryVBdGwEBAQMBAQEJA?= =?us-ascii?q?QEBFgEBAQMBAQEJAQEBgzRUfhQTjw2OSgEBgXkxAUmVOIIUhUUChQpBFwEBAQE?= =?us-ascii?q?BAQEBAQEBaiiCOCQBgkEBBTocIxALDgoJJQ8qHgYTiiStYoshAQEBAQEBAQMBA?= =?us-ascii?q?QEBASODL4VCgnk1ilogBZFLkAiUYn+BIol2hw+XLSEBNYFbVTIIgy2CXByBaT4?= =?us-ascii?q?2imYBAQE?= X-IPAS-Result: =?us-ascii?q?A2DKCgCb9OhZ/1YryVBdGwEBAQMBAQEJAQEBFgEBAQMBAQE?= =?us-ascii?q?JAQEBgzRUfhQTjw2OSgEBgXkxAUmVOIIUhUUChQpBFwEBAQEBAQEBAQEBaiiCO?= =?us-ascii?q?CQBgkEBBTocIxALDgoJJQ8qHgYTiiStYoshAQEBAQEBAQMBAQEBASODL4VCgnk?= =?us-ascii?q?1ilogBZFLkAiUYn+BIol2hw+XLSEBNYFbVTIIgy2CXByBaT42imYBAQE?= Received: from 86.43-201-80.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([80.201.43.86]) by relay.skynet.be with ESMTP; 19 Oct 2017 20:57:25 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id v9JIvOl5011200; Thu, 19 Oct 2017 20:57:25 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 19 Oct 2017 20:57:24 +0200 From: Tijl Coosemans To: Jan Beich Cc: svn-ports-head@freebsd.org, Steve Wills , svn-ports-all@freebsd.org, ports-committers@freebsd.org, Shane Subject: Re: svn commit: r452416 - in head/graphics/opensubdiv: . files Message-ID: <20171019205724.14cb4ded@kalimero.tijl.coosemans.org> In-Reply-To: <376f-c8kf-wny@FreeBSD.org> References: <201710191219.v9JCJbHV026836@repo.freebsd.org> <1slz-gioy-wny@FreeBSD.org> <20171019200428.104dc058@kalimero.tijl.coosemans.org> <376f-c8kf-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 18:57:29 -0000 On Thu, 19 Oct 2017 20:10:40 +0200 Jan Beich wrote: > Tijl Coosemans writes: >> On Thu, 19 Oct 2017 19:18:21 +0200 Jan Beich wrote: >>> Steve Wills writes: >>>> + ${FIND} ${WRKSRC}/regression -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \ >>>> + -e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/test|g' >>> >>> According to hier(7) and devel/kyua tests should probably go under >>> tests/${PORTNAME}. >>> >>> Why use xargs(1) for a feature built into find(1)? >>> >>> -exec utility [argument ...] {} + >>> Same as -exec, except that "{}" is replaced with as many >>> pathnames as possible for each invocation of utility. This >>> behaviour is similar to that of xargs(1). The primary always >>> returns true; if at least one invocation of utility returns a >>> non-zero exit status, find will return a non-zero exit status. >>> >> >> XARGS is usually faster because find runs the command for every file >> while xargs batches all files in a single command. > > Did you mistake "-exec ... {} +" for "-exec ... {} ;" ? Huh, added in 2002, I guess I haven't read that manpage in a long time.