From owner-svn-ports-head@freebsd.org Wed Mar 28 14:12:16 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28717F61A6D for ; Wed, 28 Mar 2018 14:12:16 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com [209.85.220.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4DD56CC6F for ; Wed, 28 Mar 2018 14:12:15 +0000 (UTC) (envelope-from jrm@ftfl.ca) Received: by mail-qk0-f171.google.com with SMTP id v2so2504000qkh.10 for ; Wed, 28 Mar 2018 07:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YWrOIDwqK7Hmm2XT5HeTAZHa4O+8coHMYjzaclQzJHs=; b=gTWe+mCnjZkwBqDgrQbQB9XXTTo7cTrWhY4y/2AKz3Wcrwm+ihnQj5PUGTVl0wzXCC 8ztc7F1U1FeSaIpkxRCc+KOsxq1QCUfRh8JdN2IBsdSRPAv9IAox+Ly5+CPVQPH50NUZ wc6zfZt05XVHZLE/w+JCRM2cllHerjleTdvTgwLWtZKlqgkui1IBJ607tTu8Zo6GH7qQ rg2ecfm9lTJgT4mpLY750cgwv+s8OwajjmiN53rj9Rvlrj1z1YUXlFdGlQEnijDgyVvQ Q6VB2EMf1VUAEW9BNI0arAPl9JaQl/Kw3D/Z+AClGh4RmUI1XLEvxQGco8r22flHRRpL BAug== X-Gm-Message-State: AElRT7EKFBYiTq+HGHPgZiHFfuKs1TaKr53kazT6IfbDqfnyieXVnMOA iVpg5V8EdWQQkv/AaAjbWLr/JccTxAg= X-Google-Smtp-Source: AIpwx4/Q3alZF/ecCZoNME1xmjpvLaKousxpelDXFQR/4LNDS4kQ9e65g3AwriFLCT5A8kBlGYF0mA== X-Received: by 10.55.75.146 with SMTP id y140mr5137414qka.222.1522244956347; Wed, 28 Mar 2018 06:49:16 -0700 (PDT) Received: from phe.ftfl.ca.ftfl.ca (hlfxns017vw-47-55-140-73.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.140.73]) by smtp.gmail.com with ESMTPSA id q20sm2732347qki.8.2018.03.28.06.49.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Mar 2018 06:49:15 -0700 (PDT) From: Joseph Mingrone To: "Jason W. Bacon" Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r465808 - in head/biology: . bamtools bamtools/files References: <201803281326.w2SDQVl6065909@repo.freebsd.org> <20180328134346.lw4s67embg2n4gk5@ogg.in.absolight.net> Date: Wed, 28 Mar 2018 10:49:14 -0300 In-Reply-To: <20180328134346.lw4s67embg2n4gk5@ogg.in.absolight.net> (Mathieu Arnold's message of "Wed, 28 Mar 2018 15:43:46 +0200") Message-ID: <86k1twxqcl.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 14:12:16 -0000 --=-=-= Content-Type: text/plain Mathieu Arnold writes: > On Wed, Mar 28, 2018 at 01:26:31PM +0000, Jason W. Bacon wrote: >> +LIB_DEPENDS+= libjsoncpp.so:devel/jsoncpp >> +CMAKE_ON+= BUILD_SHARED_LIBS > Why += ? Jason, maybe you missed the comments on the review? I probably should not have accepted it and commented in one go. J. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEVbCTpybDiFVxIrrVNqQMg7DW754FAlq7nVpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUACgkQNqQMg7DW 755iOw/+O8yj+8ydbBS/d+9PNCJ1HMPpG8Yghn09zAcG4jPZjAtBUmyuCaZNInJj bE3BmV+FVJs7wuIAsiDFW/6/YYiMzR/qFpZtmj9PyTfa5Q5Hhcesjeond5N7aHwh +zZu5q+yZ8Px8PO8+B75C9Db1Fp/X0A/W/n3HMpIyyVUw7SpQElfTtkcxtE+mOAd K93oGSjRuEYrgq9CSJNitUnlTvZG+4mtxr4ljTmCMMFK1rde5R7aWqxma4j6+0CO rnNC5paeXu6egK5aoZ9JsLbpmbtANpF/a0r4edTboU0LgOQnuVS+6gp2rngMimdK TVOMxeoU0/B4rEGqsGgfoHAkUO+zXTXd7thxTX0kSfNsC6CRoe/GlknSV3RYIuDP /XxxyXWZ6vvsPEndWRzeGzSmCleP+8EcrPtVXyTPpYD7kOTsKsnrfZoHiTC8p6bp qG/qL6kmIzNqGv/kNlbhz6xkZ/8SH3P84EIHRnUabksZ/Ta3Xt7mK6nQrfNMxTyp cXbyz4u6vYk0gQjs60Fs1Dd0Xv/Vj5EIgSv/lWyNm7Dl7Q2q8e0n1BdJYoXsPXRm PD/T7twkZMfBbsZrpeJA0HF3P9iPWTWeTDAG1e96amJzhP4k190A1f5w991q9Dye FRVtRXIz3UVB/1e73TRnrcV6zmLwOPVSX/9/Jir+eif2uAqF+ko= =Pkyy -----END PGP SIGNATURE----- --=-=-=--