Date: Fri, 8 Nov 2002 09:02:44 -0800 From: Juli Mallett <jmallett@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make var.c Message-ID: <20021108090244.A94144@FreeBSD.org> In-Reply-To: <200211081659.gA8GxBF3054105@repoman.freebsd.org>; from jmallett@FreeBSD.org on Fri, Nov 08, 2002 at 08:59:11AM -0800 References: <200211081659.gA8GxBF3054105@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: Juli Mallett <jmallett@FreeBSD.org> [ Data: 2002-11-08 ] [ Subjecte: cvs commit: src/usr.bin/make var.c ] > jmallett 2002/11/08 08:59:11 PST > > Modified files: > usr.bin/make var.c > Log: > Convert some broken cases where Error is called, but we try to continue, > to Fatal errors, because the logic that we use to try to continue is far > too broken, and makes things look and act weird, because we end up pointing > past the end of a buffer boundry into freed memory in the caller, as we > don't come close to setting the lengthPtr to a sane value. > > (This only changes failure cases which would have died horrid deaths to > explicit clean death failure cases.) It also brings our behaviour in these failure cases in line with OpenBSD. And closes a PR :) -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021108090244.A94144>