Date: Sat, 26 May 2012 23:30:06 GMT From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/168341: [patch] improve OptionalObsoleteFiles.inc completeness Message-ID: <201205262330.q4QNU6JX037501@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/168341; it has been noted by GNATS. From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: bug-followup@FreeBSD.org Cc: Subject: Re: misc/168341: [patch] improve OptionalObsoleteFiles.inc completeness Date: Sun, 27 May 2012 03:19:59 +0400 Here's a more complete version of the patch. Since it's quite big, it's available from http://people.freebsd.org/~amdmi3/OptionalObsoleteFiles.inc.patch - Makes OptionalObsoleteFiles.inc complete and thus delete-old targets clean (that is, what you get with `env KNOB=yes make installworld distribution` is the same as what you get with `make installworld distribution && env KNOB=yes make delete-old delete-old-libs`) for all knobs listed in src.conf(5) except for WITHOUT_MAN (too large) - All config files which may be changed by user are not touched - I've written a script to automate checking all these knobs: https://github.com/AMDmi3/obsolete-files-checker - After this patch is committed, I'll adapt it for STABLE-9 and STABLE-8 What should be reviewed: - Are all config files properly ignored (see `# intentionally left out` comments) - `${MK_CXX} == no` block had excluded usr/lib/libstdc++.so for reason; usr/lib/libsupc++.so and usr/lib32/lib{stdc++,supc++} were added there, need to confirm that they should not be excluded as well - Some files are duplicated, e.g. c++ includes in MK_CXX and MK_TOOLCHAIN - is this ok? - Some knobs also prevent build of not apparently related things, e.g. WITHOUT_LIBTHR kills ggated/ggatec, csup and libzpool - is this ok? (should be, as these utilities won't run with libthr deleted) -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205262330.q4QNU6JX037501>