From owner-freebsd-arm@freebsd.org Mon Oct 12 02:23:41 2020 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 49ED442A16A for ; Mon, 12 Oct 2020 02:23:41 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-25.consmr.mail.gq1.yahoo.com (sonic311-25.consmr.mail.gq1.yahoo.com [98.137.65.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C8jCb5l9mz4nNs for ; Mon, 12 Oct 2020 02:23:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: QmcJ5VQVM1nQGaNyIWI0W3z3MJZwnY_cg6JPBSX7YZDVEXITas23Simkssfgrdp 0PJL6a4_h2Q8HJ9CdVAsuXiRg.8YpA4nwchCLrdIBhWm3j6dBEkr6KuL4jVAKpz6aXvlCwe08tYy ZMbXId6_FAjixAkCnB2R7xAXuDzU6QePCBs6uFOzrnO8fiKPm7sxASW2Gh1aI7E70YGa9JoBWJvG 4TDHUnUrvPaxVFcNHUWQUGJb7xVyZM5trstWlY4ZP_1EmQ4sIl6dO165_iSfKIDdvDY1l6Uxh0Yb 8Y711RU3GEwl57N_r5QYJw2nzJZkVHA3lh9AiLafgY4CTBHFXJ7l9x8oMODvSYneMjKmC5MZjN6E HDsMv7DpC0Y_y9EpqctpUvqegMUhiFD.yleZpqkRuioNunbEdtrmbJrVW7dwLeUDMp2GMliCpb_O 9ufSFmlOekcv2CuvN3Pw3XODxxSoEjJQrX8jggVMx89wm2JliKsGIhQViup0cE4QR3K8MtQasyEG n0HxM4tkp_3TSJr77.YVsY_MPY83cb2z3z0DMzgVD5.i2TY0W417gTG_A2Fe6ssrlsBzqmeKPWSQ ZILk_RnC4Hv4hqbfI9r0M.xXI10gSAlUHqPLtIltCE3vhtMVHAhG3sFyUKCs6TFY7baRFJKmkNPV 4pMkxi5f.uxdZNnKRL3HkSMeQvPmdfQLRBwZwP.1mvW4Mey63e4T7Znp0QaU0bMC3cd.OCVkU24Z oGJp63WhwWaQhmy4DlIxvT7HoyeSDeur.vM0dBFCTe9b1WdfTURXCGrI4bvF.umrkXD5m06vShMh xnPYWLUqh5HQgeo3Mi40E_9H73tzoE2ggNJph0k1CXojXf5xeO71wk21EsZaRlmZdGbS9BWl_lb. Q5AHbWJpnKIB1zRoSTmd0mUe20zqiU.ccs1wTu5L380OBJP1J6jxWPOIjat812RMd8zVzVEi5jqv StDRzvG0rvWb4FP13iadTOxf68R70Iuoz9iw28jj5IcRKOkM2liXIWmBl6tuQ8EAXrF4un3jRWr4 0WppKm40_U83Wgy8eeu03py5kTtBN8WfP3u2zaJKaenZsl5g4_3m.8eg9xRlngfi_VSQ7oCFRKW_ _qCKpXQTe5PZxg0nCsZUlDKlJeBrnK8XO067nrmtFV09qgFMYQ1vljPZY.KWhdTDJ3eZRAuDEb7l Xa6CgTdocHEk82oM6yUOnwMgmYsdI8SlQiWaDd7U77hWd8kyefXQgGq7dy_VmyaY4AFqNG3Ge.Vf 5L1K2qj4ZXBUvIv_N5Gc1Yf6PdCbnqQtaTL8fmE6pT5AjFjJWrOoKFb7vNlCCglc2wTufuwr39rf tKofbXc5j4SzdJAFyXB7SbKrzVKZA_KusaLvBCdUvBX.iz.swn_4aw4p913NqFsJ7ioiN5l0pidX tLL.hnVr7j7EXZJdEBHwLdX07UpU9rY08eHPAB5Yc5mcXb3KolZ7ns3XBXJFL4M1HfMkIXiz_v0v ES1jHeaeY9tMCeMTfhhCJkvMOvpAl_5RaJeFG2h_929RpH3P8VcgW3sVdc9.BZlLHEPKONIDi8Xg O0iZLFL3nOAMSoNOCfX4Nhz7T3laqhrJdv3XGCR7BZA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Mon, 12 Oct 2020 02:23:37 +0000 Received: by smtp414.mail.gq1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d2fb6f6ac019a1256708bde9b4b76fd6; Mon, 12 Oct 2020 02:23:36 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Patches from ~gonzo/arm/rpi3-smp/u-boot-patches/ missing from u-boot upstream and from relevant sysutils/u-boot-* ports? Message-Id: <9DE1EAA1-40DB-4614-843B-73A8861098E7@yahoo.com> Date: Sun, 11 Oct 2020 19:23:36 -0700 To: Robert Crowston , Oleksandr Tymoshenko , freebsd-arm X-Mailer: Apple Mail (2.3608.120.23.2.1) References: <9DE1EAA1-40DB-4614-843B-73A8861098E7.ref@yahoo.com> X-Rspamd-Queue-Id: 4C8jCb5l9mz4nNs X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.34 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.84)[-0.836]; FREEMAIL_TO(0.00)[protonmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.03)[-1.031]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-0.98)[-0.976]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.206:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.206:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-arm] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2020 02:23:41 -0000 There are u-boot patches (from 2015-Nov-25) listed at: https://people.freebsd.org/~gonzo/arm/rpi3-smp/u-boot-patches/ that are not in u-boot and are not in the sysutils/u-boot-master or sysutils/u-boot-rpi[34] ports tree via patch-* files. arm/rpi3-smp/u-boot-patches/patch-board_raspberrypi_rpi_rpi.c looks to be what was expected to handle the values from the: https://github.com/gonzoua/rpi3-psci-monitor/blob/master/pscimon.S code (w0 and x1 before boot_kernel). That calling code (to u-boot as kernel) looks like: primary_cpu: mov sp, #RESERVE_SIZE sub sp, sp, #16 ldr w0, dtb_ptr32 bl fixup_dt_blob ldr w4, kernel_entry32 ldr w0, dtb_ptr32 mov x1, #RESERVE_SIZE boot_kernel: mov x2, #0 mov x3, #0 br x4 The matching rpi.c patch code was (in part): +static u64 fw_fdt_address __attribute__ ((section(".data"))); +static u64 reserve_memory __attribute__ ((section(".data"))); + +void save_boot_params(u64 x0, u64 x1, u64 x2, u64 x3) +{ + fw_fdt_address =3D x0; + reserve_memory =3D x1; + save_boot_params_ret(); +} + +void dram_init_banksize(void) +{ + gd->bd->bi_dram[0].start =3D CONFIG_SYS_SDRAM_BASE + = reserve_memory; + gd->bd->bi_dram[0].size =3D get_effective_memsize() - = reserve_memory; +} . . . +#ifdef CONFIG_ARM64 + if (fw_fdt_address) + setenv_hex("fdt_addr_r", (ulong)fw_fdt_address); +#endif The only "set_env.*fdt_addr_r" that I find is: # grep -r "set_env.*fdt_addr_r" ./ | more ./arch/arm/mach-uniphier/board_late_init.c: = uniphier_set_env_addr("fdt_addr_r", "fdt_addr_r_offset"); As for the line with CONFIG_SYS_SDRAM_BASE, only one match seems to be for armv8 cotnexts: # grep -r "\bd->bi_dram[0].start = =3D CONFIG_SYS_SDRAM_BASE; . . . If there is other, more modern u-boot code that covers handling the x0 and x1 from pscimon.S I have yet to notice. (But, the code is not familiar so that might not be surprising.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)