From owner-dev-commits-src-main@freebsd.org Sun Jan 31 19:12:55 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30DC8523A87; Sun, 31 Jan 2021 19:12:55 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DTLLt0WJ4z4W5J; Sun, 31 Jan 2021 19:12:53 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-ed1-f42.google.com with SMTP id n6so16399151edt.10; Sun, 31 Jan 2021 11:12:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YQvOybyGQtf5tTdd7cM49kh3e96lYO4jDEdFbwOKXE0=; b=SV+SU6MWC584DFsFbdG951nwOlVdpPv3+rUo4LcTyLzm6H7t9OPbE/uEO3tKwjuI26 zel+IbrMomUlW6V4DtwaTpbpu3QDKKdTLZQF7Yama06AUxEMWBa5AIKwJ8m47somu5Li qx1iTVPW4tlF0CfzVSfSmh7EoEsTZZdoxMWvYN3CO/pG4FVdQXSFJfST5nAY9GJjUHKS s963ma2orpGArZSrlYkPHmLl6XprZHY/l2EPJuYD9oV3UhaAnJ+LMGXPx7awYI6rK9Qi NM7c9JTAs+CKKw1MbxvkF+64GshGqHuZclWlxKUFgvwu1xkIFRZ3YplFMcbYHOJexE+4 /Zew== X-Gm-Message-State: AOAM533wuzt8M12S+IzAIkbEH5XKrmob+RJrCI4gE3cMUnUbEGhm7Zq7 zf2WU0q22QNFGi3+dDXqtWx7xmVMTg2w4cIBQhw1pknA X-Google-Smtp-Source: ABdhPJyRwRZ6VlXgqMWurE+Znh/GOTExy0TKU5PPGDlBuY2zQ/EoXIdfTw7PqhGH6crHbiWtq6ZmnTH2BAjBj+SBcfY= X-Received: by 2002:aa7:c390:: with SMTP id k16mr15135962edq.280.1612120372594; Sun, 31 Jan 2021 11:12:52 -0800 (PST) MIME-Version: 1.0 References: <202101071105.107B5tUX011254@gitrepo.freebsd.org> <20210110121242.1d9809ff@coosemans.org> In-Reply-To: <20210110121242.1d9809ff@coosemans.org> From: Antoine Brodin Date: Sun, 31 Jan 2021 20:12:42 +0100 Message-ID: Subject: Re: git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no To: Alex Richardson Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?Q?T=C4=B3l_Coosemans?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4DTLLt0WJ4z4W5J X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of antoinebrodinfreebsd@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=antoinebrodinfreebsd@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.208.42:from]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[209.85.208.42:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.42:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.42:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2021 19:12:55 -0000 On Sun, Jan 10, 2021 at 12:12 PM T=C4=B3l Coosemans wr= ote: > > On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson > wrote: > > The branch main has been updated by arichardson: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7fa2f2a62f04f095e1e27ad5= 5aa22a8f59b1df8f > > > > commit 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f > > Author: Alex Richardson > > AuthorDate: 2021-01-06 17:55:06 +0000 > > Commit: Alex Richardson > > CommitDate: 2021-01-07 09:31:03 +0000 > > > > Rename NO_WERROR -> MK_WERROR=3Dno > > > > As suggested in D27598. This also supports MK_WERROR.clang=3Dno and > > MK_WERROR.gcc=3Dno to support the existing NO_WERROR. use= s. > > > > Reviewed By: brooks > > Differential Revision: https://reviews.freebsd.org/D27601 > > --- > > diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk > > index d0e7f1cb00ba..88c73cc6bfe4 100644 > > --- a/share/mk/bsd.opts.mk > > +++ b/share/mk/bsd.opts.mk > > @@ -65,7 +65,8 @@ __DEFAULT_YES_OPTIONS =3D \ > > SSP \ > > TESTS \ > > TOOLCHAIN \ > > - WARNS > > + WARNS \ > > + WERROR > > > > __DEFAULT_NO_OPTIONS =3D \ > > BIND_NOW \ > > @@ -103,7 +104,8 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > INSTALLLIB \ > > MAN \ > > PROFILE \ > > - WARNS > > + WARNS \ > > + WERROR > > .if defined(NO_${var}) > > .error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > > MK_${var}:=3Dno > > NO_WERROR is also used by some ports [1] (which have to build against > multiple version of FreeBSD) and this turns it into an error. Can you > remove this change or turn it into a warning maybe? Changes to share/mk > should always go through a ports exp-run IMHO. Ping Alex Richardson? Antoine (with hat: portmgr)