From owner-svn-src-head@freebsd.org Fri Apr 15 14:37:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DED9AEDF99; Fri, 15 Apr 2016 14:37:10 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 181AD1942; Fri, 15 Apr 2016 14:37:10 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: by mail-ig0-x235.google.com with SMTP id ui10so24151698igc.1; Fri, 15 Apr 2016 07:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QWLfasVPmTYbtxlIjEQp2qJk4vLO+mdmt8dIPIoVLxA=; b=WJTykDxJ+vlX1usajT/vq9ZBrRJpcdI1aw+dTG/FdrU0QM0ONPOGepeK8unDlJcPy3 8RKmD8ut5BonfTQ3Db4zybKlubfqaD1RH8VKEfvnYr/RHwpsiELZf1Tw3WgOLcMpjVi7 8+GgEfFdxhIAHRG7hz4lBzrK0NvkZlbFi1rrhmqy7VYnFWCHHpgy9iOyHwOvfvqwGADz Zt+9YUTnapu2SoV1cNeTGPtFbLUjJFwEjq9L5FymA8JiGo+ZRmBlnXdC/TSdfQlzHXUK Ejtn4LuSkRUQAdCeT8Pz1sDntFtpm9TqrRkbOeE20vPS7ZusZOXXXK2ZELtrq7/hMxqf tr/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QWLfasVPmTYbtxlIjEQp2qJk4vLO+mdmt8dIPIoVLxA=; b=d8kuAUONywSbYbwGI2NllmIx8o58LVemaxo+S3kkS6ykH0AGkq7DW1bw2lJUoyKOFk 18Hgo0gHObpRp+5Ypm1Mp30CNRShCsBecMIaCnV0cTQS0/FkDrxBDUFF0vrbBgh43pEQ ykVVkvLsJLCtQGBeoaOITwKAvjd9gSm1aGUGSicTi/u803LQ7+9i+0CUl8nWrTXLIo92 dHb8dp3ID8mInBET3eZ/e6/w7xEyJoFCMA5qMQ4FInFWZOYS83Wd9iPM4co9na8kzOMQ vlqku1m/QHO1hz/dTowcSn8TARPIaNoH4Hr9qfIq4qr1eCYPkn6X8H1pNqtBYWSM3/OZ wLlA== X-Gm-Message-State: AOPr4FUX56zElPkgX67cAhwyfwdb9Si6YIhSvWrN6XUjt81LehxKrPXQT43I7lLc+HJzyyTbDGjj8ULa5bZe7Q== X-Received: by 10.50.8.40 with SMTP id o8mr1997720iga.17.1460731029330; Fri, 15 Apr 2016 07:37:09 -0700 (PDT) MIME-Version: 1.0 References: <201604150510.u3F5AWG7083767@repo.freebsd.org> In-Reply-To: From: Howard Su Date: Fri, 15 Apr 2016 14:36:59 +0000 Message-ID: Subject: Re: svn commit: r298036 - head/sys/cam To: Warner Losh Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 14:37:10 -0000 On Fri, Apr 15, 2016 at 9:26 PM Warner Losh wrote: > On Fri, Apr 15, 2016 at 12:05 AM, Howard Su wrote: > >> >> On Fri, Apr 15, 2016 at 1:10 PM Warner Losh wrote: >> >>> Author: imp >>> Date: Fri Apr 15 05:10:32 2016 >>> New Revision: 298036 >>> URL: https://svnweb.freebsd.org/changeset/base/298036 >>> >>> Log: >>> Put function only used by CAM_NETFLIX_IOSCHED under that ifdef. >>> >>> I suggest to remove NETFLIX from the name. >> > > It's the Netflix I/O scheduler as opposed to the default one. So the > name is appropriate. It's better than CAM_WARNER_AWESOME_IOSCHED > which is the only other choice possible... :) > The name didn't give any information about what it is and what it do thing differently. Sounds like this is only useful for netflix and other people should not bother to use it. If so, this is proper name. > > Warner > > >> Modified: >>> head/sys/cam/cam_iosched.c >>> >>> Modified: head/sys/cam/cam_iosched.c >>> >>> ============================================================================== >>> --- head/sys/cam/cam_iosched.c Fri Apr 15 05:10:31 2016 (r298035) >>> +++ head/sys/cam/cam_iosched.c Fri Apr 15 05:10:32 2016 (r298036) >>> @@ -625,9 +625,11 @@ cam_iosched_cl_maybe_steer(struct contro >>> /* Periph drivers set these flags to indicate >>> work */ >>> #define CAM_IOSCHED_FLAG_WORK_FLAGS ((0xffffu) << 16) >>> >>> +#ifdef CAM_NETFLIX_IOSCHED >>> static void >>> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >>> sbintime_t sim_latency, int cmd, size_t size); >>> +#endif >>> >>> static inline int >>> cam_iosched_has_flagged_work(struct cam_iosched_softc *isc) >>> @@ -1522,6 +1524,7 @@ cam_iosched_update(struct iop_stats *iop >>> iop->sd = (int64_t)var < 0 ? 0 : isqrt64(var); >>> } >>> >>> +#ifdef CAM_NETFLIX_IOSCHED >>> static void >>> cam_iosched_io_metric_update(struct cam_iosched_softc *isc, >>> sbintime_t sim_latency, int cmd, size_t size) >>> @@ -1541,6 +1544,7 @@ cam_iosched_io_metric_update(struct cam_ >>> break; >>> } >>> } >>> +#endif >>> >>> #ifdef DDB >>> static int biolen(struct bio_queue_head *bq) >>> _______________________________________________ >>> svn-src-head@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-head >>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >>> >>