Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jun 2016 13:01:08 +0000
From:      Glen Barber <gjb@FreeBSD.org>
To:        "Simon J. Gerraty" <sjg@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r301713 - head/sys/dev/random
Message-ID:  <20160609130108.GN2323@FreeBSD.org>
In-Reply-To: <201606090150.u591ohZa019497@repo.freebsd.org>
References:  <201606090150.u591ohZa019497@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--wmhq21yAGFMoSpeN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 09, 2016 at 01:50:43AM +0000, Simon J. Gerraty wrote:
> Author: sjg
> Date: Thu Jun  9 01:50:43 2016
> New Revision: 301713
> URL: https://svnweb.freebsd.org/changeset/base/301713
>=20
> Log:
>   Add a prototype for random_harvest_queue to dev/random/random_harvestq.h
>   This fixes a warning that occurs in a number of files that use the
>   random_harvest_queue function.
>  =20
>   Differential Revision:	https://reviews.freebsd.org/D4229
>   Submitted by:	stevek@juniper.net
>   Reviewed by:	markm
>   Approved by:	so
>=20
> Modified:
>   head/sys/dev/random/random_harvestq.h
>=20
> Modified: head/sys/dev/random/random_harvestq.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/dev/random/random_harvestq.h	Thu Jun  9 01:31:09 2016	(r3017=
12)
> +++ head/sys/dev/random/random_harvestq.h	Thu Jun  9 01:50:43 2016	(r3017=
13)
> @@ -43,7 +43,9 @@ struct harvest_event {
>  	uint8_t		he_source;		/* origin of the entropy */
>  } __packed;
> =20
> -void read_rate_increment(u_int);
> +void	random_harvest_queue(const void *, u_int, u_int,
> +	    enum random_entropy_source);
> +void	read_rate_increment(u_int);
> =20
>  #define	RANDOM_HARVESTQ_BOOT_ENTROPY_FILE	"/boot/entropy"
> =20

This breaks sparc64.

cc1: warnings being treated as errors
In file included from /usr/src/sys/modules/random_other/../../dev/random/ot=
her_algorithm.c:62:
/usr/src/sys/dev/random/random_harvestq.h:47: warning: redundant redeclarat=
ion of 'random_harvest_queue' [-Wredundant-decls]
/usr/src/sys/sys/random.h:99: warning: previous declaration of 'random_harv=
est_queue' was here

Glen


--wmhq21yAGFMoSpeN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXWWiUAAoJEAMUWKVHj+KTcFMP/RPEOU14PFRuFLyA16SYgL0u
CeoHfHOnTl3sjyb2fGmcdQn/a+rQDY1yFNNVidKvT0ZgPxlN66nX06F8GrK2BzhY
SJZ8bOtp3MHPj7msRNrtnR47QiqxAbBFoci7nz3bBPr1R3QU5MKGQ2ZpKlAkA1Y1
EErLYF3nXJqaTiE7i2B17/+sKSRvOy/Lxv0By4ZD/T57KzblK6aNdSJyqpFVP1Zx
GhiuG4uy4L5+LgcHTaz3GNLrZpJ1j2ncDSTp/uVv/r9QENBpvgs6D8XVklkEqIuN
VFzxsUQxs6lq7iOY1nZ4UytpeDwqnAXMkQnJ2oz0XMoAP+9Y1PaJBahKOiX8vm6S
D9YQhraGQxKLNSYJ8K3/6yKlP688ssGGK+ILAcaSYluIL6Gd9J+IJWXWRGuLaabq
Jhqt59VgczetwhlpN/7IDZ4cYeMn4CRHP/bav8h7s392/MAhrUlqMU3pgv5ugxCo
SP9JWrawdQ5iiqq4ju+AWGCXw8fB0V7uYvQupM9DbL/VGJ0GyjCsMsY+0Xgx/9rc
DnRpCuJ7zfSTFrpY+Atsk2UzAi5G9A0ZafgrQtMPK9Sm1NQqTdGO+KGBznufGs7X
5s4v6ZkS1BEhAgfBZevxoL5sNTb0Wz4eSzRe/g4lezAf3F30+/D89GsjggqPbfXx
upCdHufQyYNKtw8+9tn0
=AA/o
-----END PGP SIGNATURE-----

--wmhq21yAGFMoSpeN--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160609130108.GN2323>