From owner-svn-src-head@FreeBSD.ORG Thu Jan 22 21:09:52 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2B1DC20; Thu, 22 Jan 2015 21:09:52 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 79A0D610; Thu, 22 Jan 2015 21:09:52 +0000 (UTC) Received: from moby.local ([91.89.177.101]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M2ts6-1XPJpF1uze-00sb7B; Thu, 22 Jan 2015 22:09:47 +0100 Message-ID: <54C16715.6060701@gmx.com> Date: Thu, 22 Jan 2015 22:09:41 +0100 From: Nikos Vassiliadis User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Gleb Smirnoff , Craig Rodrigues Subject: Re: svn commit: r276747 - head/sys/netpfil/pf References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> In-Reply-To: <20150122012709.GM15484@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:UiwhKkbDCweNofu3FvHAFs6cQti7PbSP5bweQMnDr2uPkaLW0Vf pia8RYpDbfzh3KrvGKG1qrDZ11mU+qWAxbt0AtZ7jVa7247l3ozidFRBpZI99zSeCwqZVjf pSfjBzHn76ea8kADyJTwePTxnc85GDwTQ89GdmSBvy/33Ozit4h5gbK1tpAjBJIZEVvteGj l2FAp92bDTk0Nqyb/7wxQ== X-UI-Out-Filterresults: notjunk:1; Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 21:09:53 -0000 On 01/22/15 02:27, Gleb Smirnoff wrote: > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: > C> Author: rodrigc > C> Date: Tue Jan 6 09:03:03 2015 > C> New Revision: 276747 > C> URL: https://svnweb.freebsd.org/changeset/base/276747 > C> > C> Log: > C> Instead of creating a purge thread for every vnet, create > C> a single purge thread and clean up all vnets from this thread. > C> > C> PR: 194515 > C> Differential Revision: D1315 > C> Submitted by: Nikos Vassiliadis > > Sorry guys, I backed this out due to broken kldunload of pf module, which > is critical when you are working with pf bugs. For sure. 100% understood. > I had to backout r276746 as well, since it has numerous build breakages, > that are addressed by later revisions. > > That's my fault that I don't review in time, and I will try to improve > the situation. > > Can you please replay r276746 again, addressing all the build problems > and send the patch to me? You can user reviews.freebsd.org if you want. > > I'd like to get this in, but in a better quality. I'd like to get involved again and help you fixing pf. Craig could you replay 276746? I can try fixing the pf purge thread. Thanks, Nikos