From owner-freebsd-qa@FreeBSD.ORG Fri Mar 19 21:07:36 2010 Return-Path: Delivered-To: freebsd-qa@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDD981065672 for ; Fri, 19 Mar 2010 21:07:36 +0000 (UTC) (envelope-from chukharev@mail.ru) Received: from mx34.mail.ru (mx34.mail.ru [94.100.176.48]) by mx1.freebsd.org (Postfix) with ESMTP id 850648FC1B for ; Fri, 19 Mar 2010 21:07:36 +0000 (UTC) Received: from [91.155.189.108] (port=60075 helo=vova-vaio) by mx34.mail.ru with asmtp id 1NsjPq-000PeJ-00 for freebsd-qa@freebsd.org; Sat, 20 Mar 2010 00:07:34 +0300 Content-Type: text/plain; charset=koi8-r; format=flowed; delsp=yes In-Reply-To: <3cb459ed1003170558s45d0d7bcv96094f28efb68a24@mail.gmail.com> References: <3cb459ed1003160605x2eb9fe76h28ba8bdc35f9f3c@mail.gmail.com> <20100316134607.GA3204@straylight.ringlet.net> <3cb459ed1003170558s45d0d7bcv96094f28efb68a24@mail.gmail.com> To: freebsd-qa@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: chukharev@mail.ru Date: Fri, 19 Mar 2010 23:07:30 +0200 Message-ID: User-Agent: Opera Mail/10.10 (FreeBSD) X-Spam: Not detected X-Mras: Ok Subject: Re: About ports QA by 'port test' X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2010 21:07:36 -0000 On Wed, 17 Mar 2010 14:58:49 +0200, Alexander Churanov wrote: > Folks, > > If the portlint would be told to ignore errors like missing PORTVERSION, > then how do you know whether the port is correct or not? > > From my point of view, the issue is the portlint pretends to parse > makefiles, but does not implement full make :-). For example, as far as I > understand, the line 2188 just verifies that the file has a line starting > with PORTVERSION. Portlint should use "make -V PORTVERSION" instead. It's true that portlint parses makefiles. But I believe its task is checking style, not implementing make. Correctness is checked by the next stage of the test. I have modified the script so that a FATAL error of portlint does not stop the test. One more file is used for results of portlint now. New results will come to the site as the test is run over the list of the installed ports. > Alexander Churanov, > maintainer of devel/boost-* devel/boost* have style of implementing related ports really different from recommended in FreeBSD Porter's Handbook section 5.8 MASTERDIR. So, the reason for complains from portlint is stylistic disagreement ;-) -- Vladimir Chukharev Tampere University of Technology