From owner-p4-projects@FreeBSD.ORG  Sat Feb  2 07:18:07 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 64B4A16A469; Sat,  2 Feb 2008 07:18:07 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 11BB316A418;
	Sat,  2 Feb 2008 07:18:07 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
Received: from swip.net (mailfe01.swip.net [212.247.154.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 50BC813C46E;
	Sat,  2 Feb 2008 07:18:06 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
X-Cloudmark-Score: 0.000000 []
Received: from [85.19.218.18] (account mc467741@c2i.net [85.19.218.18]
	verified) by mailfe01.swip.net (CommuniGate Pro SMTP 5.1.13)
	with ESMTPA id 768799855; Sat, 02 Feb 2008 08:18:04 +0100
From: Hans Petter Selasky <hselasky@freebsd.org>
To: Alfred Perlstein <alfred@freebsd.org>
Date: Sat, 2 Feb 2008 08:18:56 +0100
User-Agent: KMail/1.9.7
References: <200712020001.lB201XbN000811@repoman.freebsd.org>
	<20080202022234.GR99258@elvis.mu.org>
In-Reply-To: <20080202022234.GR99258@elvis.mu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802020818.57037.hselasky@freebsd.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 129920 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Feb 2008 07:18:07 -0000

On Saturday 02 February 2008, Alfred Perlstein wrote:
> This change makes very little sense.  If xfer->frbuffers is a bare
> pointer, then why add 0 to it?  Just pass xfer->frbuffers or use a
> macro that explains what you are doing.
>

I can change those to a plain "xfer->frlengths". It was just a reminder for 
me, because some places we use "xfer->frlengths + 1" and "xfer->frbuffers + 
1".

I will write a script that converts all of those.

--HPS