From owner-svn-src-all@freebsd.org Thu Mar 22 13:56:08 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D5EBF697C6; Thu, 22 Mar 2018 13:56:08 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B249F75A38; Thu, 22 Mar 2018 13:56:07 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x231.google.com with SMTP id r18so11062569ioa.1; Thu, 22 Mar 2018 06:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=uakfouoawlKl1TFqxIkqZ1IrFaRs9rQ+4AdTL9GNk7o=; b=OcHvDgJ6bEHCQtV+a3sxiBD4GSXuSUZYdmpqLNDkDMVmfdSAMEoH0lUWr+/nExsI2i 1ViINsiBw20wLYLGkdJ5TpletIgQmx6AUjjJHHfxN662MJ7fvES1AamIYPYIYsVgRSWw HBO2l+gJ8BkqLRJhQ/oOyo7RGaS1WcS8mbAFZKFTHD1GfFo+J8cHdAfo2iNtoPBzZS/v YkmigSxhjV5gSYpOplHXVD4ml56/2MUOaKzLYGMCUvSqrXOe+m64SY8Ibtmg1OZ6bYSH +Qe5R8fEJds2Zr0C9FzxEOxn1jyxMgOfAt+rPRdbd7tjcsQbnkm2WPy40ACFzaRNtJhV EqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=uakfouoawlKl1TFqxIkqZ1IrFaRs9rQ+4AdTL9GNk7o=; b=I9JTSIkTgwHyGMwHh5oYLFCajqIPfe1dxLNV+wgDno+XIr7VCX8m0GBE6b6/skqEvB 62X+xLJcRGJQumn2rI1+0wa1BqdxMaTpfvIigbDdgmXCTS2xb+kYun23KFSnDt79kBT9 0B8bqXKXyZ2Bk1zEO3/rVDiZ5R7CzwJ7jm0d/Nu62LTeZS5kld9nL6P8qw5dEMVWBjDm QMczw7QPjCWVfKcwJf3Z/EJBBCzjP6qNfmA1/17FYHTVmD78T58Pv/8yvkj/3RsUwrih HKSSoaRkqcPOfNrH4VU2bmD7qatHOah0eIG8Xz62xbX9+SKWh96PRttXmyvccWXTwgAM SFqw== X-Gm-Message-State: AElRT7EXav3LoRAh1QZS4pyFapNTdC6ls0W1GgbYFNrhuSF6r0W9GkHT 4GQYV6rxubNYseY7VWb0NcpMMfYcx1NAQa6MufBTixVD X-Google-Smtp-Source: AG47ELuukn/u9thJ3wP/pcHD2ajMKg+x7vpp7RB6axhIrtQipdT/5dn2e6ivdOWQysBtEL9so7uhvi//cfaXEP+empg= X-Received: by 10.107.46.30 with SMTP id i30mr26172402ioo.288.1521726966887; Thu, 22 Mar 2018 06:56:06 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.163.13 with HTTP; Thu, 22 Mar 2018 06:55:46 -0700 (PDT) In-Reply-To: <201803221258.w2MCwov4067050@repo.freebsd.org> References: <201803221258.w2MCwov4067050@repo.freebsd.org> From: Ed Maste Date: Thu, 22 Mar 2018 09:55:46 -0400 X-Google-Sender-Auth: Lv1kjfuXu3eOel0uMMZUX4ulMvo Message-ID: Subject: Re: svn commit: r331356 - in head: lib/libsysdecode sys/amd64/linux sys/amd64/linux32 sys/compat/linux sys/i386/linux sys/modules/linux_common To: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 13:56:08 -0000 On 22 March 2018 at 08:58, Ed Maste wrote: > Author: emaste > Date: Thu Mar 22 12:58:49 2018 > New Revision: 331356 > URL: https://svnweb.freebsd.org/changeset/base/331356 > > Log: > Share Linux errno table with libsysdecode I had a question about using ".inc" vs ".h". I followed the ".inc" convention from some examples in llvm and elsewhere, because linux_errno.inc is unlike regular headers - it's not idempotent, and the array has to be the first non-comment content in the file because it's prefixed with "static" before one of the #includes.