Date: Thu, 12 Mar 2020 04:22:35 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528226 - in head/net-p2p: . udpt udpt/files Message-ID: <20200312042235.GA66660@FreeBSD.org> In-Reply-To: <20200311180936.dbjgbynjmbxstukk@ivaldir.net> References: <202003111051.02BApxf7054140@repo.freebsd.org> <20200311180936.dbjgbynjmbxstukk@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 11, 2020 at 07:09:36PM +0100, Baptiste Daroussin wrote: > On Wed, Mar 11, 2020 at 10:51:59AM +0000, Alexey Dokuchaev wrote: > > New Revision: 528226 > > URL: https://svnweb.freebsd.org/changeset/ports/528226 > > > > Log: > > UDPT is a lightweight UDP torrent tracker for Unix-like systems. > > ... Please don't overquote. > > +# Alternative to DOS2UNIX_FILES that preserves original timestamps, > > +# to be used together with `-l' switch added to PATCH_ARGS below. > > +fixpatches: > > + @${FIND} ${FILESDIR} -name patch-* | ${XARGS} ${SED} -i '' \ > > + -E 's,[[:cntrl:]]*$$,,' > > +PATCH_ARGS+= -l > > Seriously? why not improving the framework instead??? Admittedly, I'm not quite sure that it's the framework that should be fixed rather than SVN rules laxed to allow mixed line endings. While I hate CRLF as much as anyone else, technically there's nothing wrong with patches that patch DOS-style code generated on Unix, thus having LF-ended header and CRLF or even mixed body. I'd say that people use DOS2UNIX in this case mainly to circumvent SVN commit hooks. That said, it still can be handled within the framework, but the most straightforward way as I see it would require PATCH_ARGS+=-l and I am not sure if that's acceptable. There are probably other ways I don't see, of course, but then again, why not just fine-tune SVN? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200312042235.GA66660>