Date: Fri, 1 May 2015 00:50:13 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385072 - head/x11/lumina Message-ID: <20150430225013.GO13141@ivaldir.etoilebsd.net> In-Reply-To: <h9rx-w7w6-wny@FreeBSD.org> References: <201504302212.t3UMClq7091335@svn.freebsd.org> <h9rx-w7w6-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--w6U88vdWm8UqIXvc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, May 01, 2015 at 12:47:37AM +0200, Jan Beich wrote:
> Kris Moore <kmoore@FreeBSD.org> writes:
>=20
> > -PORTVERSION=3D 0.8.3.${GITVERSION}
> > -PORTEPOCH=3D 1
> > +PORTVERSION=3D 0.8.4
> > +PORTREVISION=3D 1
>=20
> PORTEPOCH cannot be removed.
>=20
> $ portlint -C
> FATAL: Makefile: lumina-0.8.4_1 < lumina-0.8.3.1427733141,1. Choose anoth=
er PORTVERSION or bump PORTEPOCH.
>=20
> > +USE_GITHUB=3D yes
> > +GH_ACCOUNT=3D pcbsd
> > +GH_COMMIT=3D 01bfb64
> > +GH_TAGNAME=3D v0.8.4-Release-P1
>=20
> GH_COMMIT is deprecated and GH_TAGNAME is often a superset of PORTVERSION.
> Also, spaces instead of tabs.
>=20
> $ portlint -C
> FATAL: Makefile: [43]: use a tab (not space) after a variable name
> FATAL: Makefile: [44]: use a tab (not space) after a variable name
> FATAL: Makefile: [45]: use a tab (not space) after a variable name
> FATAL: Makefile: [46]: use a tab (not space) after a variable name
>=20
> Index: x11/lumina/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- x11/lumina/Makefile (revision 385072)
> +++ x11/lumina/Makefile (working copy)
> @@ -3,7 +3,9 @@
> =20
> PORTNAME=3D lumina
> PORTVERSION=3D 0.8.4
> -PORTREVISION=3D 1
> +DISTVERSIONPREFIX=3Dv
> +DISTVERSIONSUFFIX=3D-Release-P1
> +PORTEPOCH=3D 1
> CATEGORIES=3D x11
> =20
> MAINTAINER=3D kmoore@FreeBSD.org
> @@ -40,10 +42,8 @@ USE_LDCONFIG=3D yes
> USE_QT5=3D core gui network svg linguist multimedia imageformats \
> buildtools x11extras
> USES=3D qmake tar:bzip2
> -USE_GITHUB=3D yes
> -GH_ACCOUNT=3D pcbsd
> -GH_COMMIT=3D 01bfb64
> -GH_TAGNAME=3D v0.8.4-Release-P1
> +USE_GITHUB=3D yes
> +GH_ACCOUNT=3D pcbsd
> =20
> QMAKE_ARGS=3D CONFIG+=3D"configure"
> =20
> Index: x11/lumina/distinfo
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- x11/lumina/distinfo (revision 385072)
> +++ x11/lumina/distinfo (working copy)
> @@ -1,2 +1,2 @@
> -SHA256 (lumina-0.8.4.tar.bz2) =3D 311114964e900132a09e9acac46958da09d7ff=
b12a3e1d7653147b8952f658f0
> -SIZE (lumina-0.8.4.tar.bz2) =3D 23261871
> +SHA256 (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 5d54f60a534ea8d9=
2259a6f57074173d9721492b7148a5fa5bcf8894beeffaf6
> +SIZE (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 23261876
100% agree with Jan + remove tar:bzip2 github only provides tar.gz even is =
you
do ask a bzip2 :)
Best regards,
Bapt
--w6U88vdWm8UqIXvc
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlVCsaUACgkQ8kTtMUmk6EyAWwCgk6I98QjljPkKWBZJRi+kPrXx
kecAoLKTPngzVSkdWnrsoEw7yT+uxlb1
=nUWI
-----END PGP SIGNATURE-----
--w6U88vdWm8UqIXvc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150430225013.GO13141>