From owner-cvs-all@FreeBSD.ORG  Wed Jun  4 20:27:25 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DE04F37B401; Wed,  4 Jun 2003 20:27:25 -0700 (PDT)
Received: from canning.wemm.org (canning.wemm.org [192.203.228.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 511B943F3F; Wed,  4 Jun 2003 20:27:25 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by canning.wemm.org (Postfix) with ESMTP
	id 336B42A8C1; Wed,  4 Jun 2003 20:27:25 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: "Daniel C. Sobral" <dcs@tcoip.com.br>
In-Reply-To: <3EDE3905.7020506@tcoip.com.br> 
Date: Wed, 04 Jun 2003 20:27:25 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20030605032725.336B42A8C1@canning.wemm.org>
cc: cvs-src@FreeBSD.org
cc: Tony Finch <fanf@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Mike Barcroft <mike@FreeBSD.org>
Subject: Re: cvs commit: src/tools/regression/usr.bin/sed regress.s3.out
	regress.s4.out regress.s5.out regress.sg.out regress.sh 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jun 2003 03:27:26 -0000

"Daniel C. Sobral" wrote:
> Mike Barcroft wrote:
> > Tony Finch <fanf@FreeBSD.org> writes:
> > 
> >>fanf        2003/06/04 08:26:24 PDT
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    tools/regression/usr.bin/sed regress.sh 
> >>  Added files:
> >>    tools/regression/usr.bin/sed regress.s3.out regress.s4.out 
> >>                                 regress.s5.out regress.sg.out 
> >>  Log:
> >>  Add tests for the behaviour of substitution when the regex can match
> >>  a zero-length string. This shows bugs in the s///g and s///2+ cases.
> 
> Let me add my thanks too. This kind of bug is the worst kind possible. 
> Particularly when you _don't_ detect it, and end up with flawed data.

In this case however, the cure is worse than the disease.  World wont build
anymore since sed is now broken.  'make world' seems to be a better
basic regression test in this instance.

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5