From owner-cvs-all  Sat Jun 22 11:37:22 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3167837B40E; Sat, 22 Jun 2002 11:37:08 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id EAA25786;
	Sun, 23 Jun 2002 04:37:01 +1000
Date: Sun, 23 Jun 2002 04:42:01 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Mark Peek <mp@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/isa clock.c
In-Reply-To: <200206221630.g5MGUJH76448@freefall.freebsd.org>
Message-ID: <20020623043726.K9398-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sat, 22 Jun 2002, Mark Peek wrote:

> mp          2002/06/22 09:30:19 PDT
>
>   Modified files:
>     sys/i386/isa         clock.c
>   Log:
>   Clock frequencies reported by sysctl should be unsigned values. Discovered
>   when machdep.tsc_freq returned a negative number on a 2.2GHz Xeon.

Actually, they should be positive values.  Signed types are useful for
detection of overflow.

"int profrate" in <sys/gmon.h> is also broken.  It needs to hold any
clock frequency.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message