From owner-cvs-all Fri Jul 12 2:14:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBCB337B400; Fri, 12 Jul 2002 02:14:10 -0700 (PDT) Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B60443E3B; Fri, 12 Jul 2002 02:14:10 -0700 (PDT) (envelope-from hsu@FreeBSD.org) Received: from FreeBSD.org ([63.193.112.125]) by mta7.pltn13.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with ESMTP id <0GZ400HU7PNLLG@mta7.pltn13.pbi.net>; Fri, 12 Jul 2002 02:14:10 -0700 (PDT) Date: Fri, 12 Jul 2002 02:14:38 -0700 From: Jeffrey Hsu Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c In-reply-to: Message from Don Lewis "of Fri, 12 Jul 2002 01:46:59 PDT." <200207120847.g6C8kxwr013248@gw.catspoiler.org> To: Don Lewis Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Message-id: <0GZ400HU8PNLLG@mta7.pltn13.pbi.net> MIME-version: 1.0 X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > Comparing udp_getcred() with tcp_getcred(), the missing lock looked like > an oversight. Okay, I see the confusion. I had the same question when I reviewed Jennifer's patch, but decided to err on the side of conservatism and allow it. I actually believe that lock is unnecessary in tcp_getcred(). > Isn't it possible for inp->inp_socket to get modified by > another thread in either case unless inp is locked? Unless I missed a code path, I don't see how that can happen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message