From owner-svn-src-head@FreeBSD.ORG  Sun Nov 23 12:34:38 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1658D1065672;
	Sun, 23 Nov 2008 12:34:38 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88])
	by mx1.freebsd.org (Postfix) with ESMTP id C6C858FC0C;
	Sun, 23 Nov 2008 12:34:37 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from [202.179.21.135] (helo=devil.micom.mng.net)
	by publicd.ub.mng.net with esmtpa (Exim 4.69 (FreeBSD))
	(envelope-from <ganbold@micom.mng.net>)
	id 1L4DnQ-0006l7-7R; Sun, 23 Nov 2008 20:10:36 +0800
Message-ID: <4929483B.9070404@micom.mng.net>
Date: Sun, 23 Nov 2008 20:10:35 +0800
From: Ganbold <ganbold@micom.mng.net>
User-Agent: Thunderbird 2.0.0.17 (X11/20081020)
MIME-Version: 1.0
To: Alexander Motin <mav@FreeBSD.org>
References: <200811221655.mAMGttpJ023528@svn.freebsd.org>
In-Reply-To: <200811221655.mAMGttpJ023528@svn.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=78F6425E
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r185183 - head/sys/netgraph
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Nov 2008 12:34:38 -0000

Alexander Motin wrote:
> Author: mav
> Date: Sat Nov 22 16:55:55 2008
> New Revision: 185183
> URL: http://svn.freebsd.org/changeset/base/185183
>
> Log:
>   Remove unused variable.
>   
>   Found with:     Coverity Prevent(tm)
>   CID:            3682
>
> Modified:
>   head/sys/netgraph/ng_socket.c
>
> Modified: head/sys/netgraph/ng_socket.c
> ==============================================================================
> --- head/sys/netgraph/ng_socket.c	Sat Nov 22 16:40:12 2008	(r185182)
> +++ head/sys/netgraph/ng_socket.c	Sat Nov 22 16:55:55 2008	(r185183)
> @@ -259,9 +259,8 @@ ngc_send(struct socket *so, int flags, s
>  	if (msg->header.typecookie == NGM_GENERIC_COOKIE &&
>  	    msg->header.cmd == NGM_MKPEER) {
>  		struct ngm_mkpeer *const mkp = (struct ngm_mkpeer *) msg->data;
> -		struct ng_type *type;
>  
> -		if ((type = ng_findtype(mkp->type)) == NULL) {
> +		if (ng_findtype(mkp->type) == NULL) {
>  			char filename[NG_TYPESIZ + 3];
>  			int fileid;
>  
> @@ -275,7 +274,7 @@ ngc_send(struct socket *so, int flags, s
>  			}
>  
>  			/* See if type has been loaded successfully. */
> -			if ((type = ng_findtype(mkp->type)) == NULL) {
> +			if (ng_findtype(mkp->type) == NULL) {
>  				free(msg, M_NETGRAPH_MSG);
>  				(void)kern_kldunload(curthread, fileid,
>  				    LINKER_UNLOAD_NORMAL);
>   

Thanks, what a coincident :)
I have sent exactly same patch to rwatson@ and glebius@ yesterday night :)

Ganbold

> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>
>
>
>   


-- 
Old Grandad is dead but his spirits live on.