From owner-freebsd-net  Thu Aug 30 12:17:12 2001
Delivered-To: freebsd-net@freebsd.org
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2271C37B407; Thu, 30 Aug 2001 12:17:04 -0700 (PDT)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id MAA75759;
	Thu, 30 Aug 2001 12:05:49 -0700 (PDT)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.11.3/8.11.3) id f7UJ5m043601;
	Thu, 30 Aug 2001 12:05:48 -0700 (PDT)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200108301905.f7UJ5m043601@arch20m.dellroad.org>
Subject: Re: kernel panic when bringing up a VLAN interface (netgraph?)
In-Reply-To: <20010830195759.A21176@comp.chem.msu.su> "from Yar Tikhiy at Aug
 30, 2001 07:58:00 pm"
To: Yar Tikhiy <yar@FreeBSD.ORG>
Date: Thu, 30 Aug 2001 12:05:48 -0700 (PDT)
Cc: Archie Cobbs <archie@dellroad.org>,
	Mike Tancsa <mike@sentex.net>, stable@FreeBSD.ORG, net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL82 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

Yar Tikhiy writes:
> I'd suggest the following fix.  Not sure if it should be pushed
> into the upcoming 4.4-RELEASE...
> 
> Index: ng_ether.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/netgraph/ng_ether.c,v
> retrieving revision 1.18
> diff -u -r1.18 ng_ether.c
> --- ng_ether.c	2001/01/30 20:51:52	1.18
> +++ ng_ether.c	2001/08/30 15:33:24
> @@ -798,7 +798,8 @@
>  
>  		/* Create nodes for any already-existing Ethernet interfaces */
>  		TAILQ_FOREACH(ifp, &ifnet, if_link) {
> -			if (ifp->if_type == IFT_ETHER)
> +			if (ifp->if_type == IFT_ETHER ||
> +			    ifp->if_type == IFT_L2VLAN)
>  				ng_ether_attach(ifp);
>  		}
>  		break;

Yes, this is the correct fix .. nice and simple :-)

Definitely a MFC candidate.

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message