From owner-cvs-ports@FreeBSD.ORG  Sat Mar 13 16:05:15 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 499A916A4CE; Sat, 13 Mar 2004 16:05:15 -0800 (PST)
Received: from mtaw6.prodigy.net (mtaw6.prodigy.net [64.164.98.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 37E2143D2D; Sat, 13 Mar 2004 16:05:15 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(849ffd6e014943a5c269597ee079b6b9@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])
	by mtaw6.prodigy.net (8.12.10/8.12.10) with ESMTP id i2E04C3g009085;
	Sat, 13 Mar 2004 16:04:12 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 05DCE5131A; Sat, 13 Mar 2004 16:05:13 -0800 (PST)
Date: Sat, 13 Mar 2004 16:05:13 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Joe Marcus Clarke <marcus@FreeBSD.org>
Message-ID: <20040314000513.GB65109@xor.obsecurity.org>
References: <200403131801.i2DI1Xqn098604@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="JYK4vJDZwFMowpUq"
Content-Disposition: inline
In-Reply-To: <200403131801.i2DI1Xqn098604@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/x11-toolkits/py-gtk2 Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Mar 2004 00:05:15 -0000


--JYK4vJDZwFMowpUq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 13, 2004 at 10:01:33AM -0800, Joe Marcus Clarke wrote:
> marcus      2004/03/13 10:01:33 PST
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     x11-toolkits/py-gtk2 Makefile=20
>   Log:
>   Correct a typo that prevented thread support from being enabled.
>  =20
>   Submitted by:   Davide D'Amico <dave@civetta.gufi.org>

Why is this necessary?

> | -LIBC_R!=3D	/sbin/ldconfig -r | grep "c_r|pthread" || true
> | +LIBC_R!=3D	/sbin/ldconfig -r | grep "c_r\|pthread" || true
> |  .if (${LIBC_R} !=3D "") && !defined(WITHOUT_THREADS)
> |  CONFIGURE_ARGS+=3D	--enable-thread
> |  CFLAGS+=3D		${PTHREAD_CFLAGS}

By default, every FreeBSD platform supports threads in one form or
another (but via the same interface, PTHREAD_{CFLAGS,LIBS}) -- your
test omits testing for libthr, by the way.  The only way someone will
have arrived at a system without threads is if they have disabled it
with make.conf variables, so can't you just test for those if you want
to support those systems?

Kris

--JYK4vJDZwFMowpUq
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAU6G5Wry0BWjoQKURAnfRAKDgeK/PvKovqYmGXazfY4cRYlUaRACgnrHU
KiTXUq3BhMhiEFIeDWaDPdE=
=ZioY
-----END PGP SIGNATURE-----

--JYK4vJDZwFMowpUq--