From owner-cvs-all Thu Feb 27 12:57:45 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 86A3837B401; Thu, 27 Feb 2003 12:57:43 -0800 (PST) Received: from procyon.firepipe.net (procyon.firepipe.net [198.78.66.151]) by mx1.FreeBSD.org (Postfix) with ESMTP id D845843FA3; Thu, 27 Feb 2003 12:57:42 -0800 (PST) (envelope-from will@csociety.org) Received: by procyon.firepipe.net (Postfix, from userid 1000) id 53C0021D15; Thu, 27 Feb 2003 12:57:42 -0800 (PST) Date: Thu, 27 Feb 2003 12:57:42 -0800 From: Will Andrews To: Maxim Sobolev Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall index.c Message-ID: <20030227205742.GT37397@procyon.firepipe.net> References: <200302272043.h1RKhq9f048530@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200302272043.h1RKhq9f048530@repoman.freebsd.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Feb 27, 2003 at 12:43:52PM -0800, Maxim Sobolev wrote: > Log: > Increase size of the static buffer used to hold runtime dependency list > read from CD from 2k to 16k, because in the modern world of meta-packages > (Gnome et al) the length of this list could easily owerflow limit causing > strange things to happen, ranging from installation failure due to list > truncation to complete stack trashing (there is very vague bounds checking). > For example, x11/gnome2-fifth-toe runtime dependencies list is 2,418 bytes > long. Why not do it right the first time? Make it a dynamic buffer instead of a static one. Regards, -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message