From owner-svn-src-projects@freebsd.org Mon Apr 22 17:42:00 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63A1515A0291 for ; Mon, 22 Apr 2019 17:42:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB2D66EC46; Mon, 22 Apr 2019 17:41:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x434.google.com with SMTP id 9so6022189pfj.13; Mon, 22 Apr 2019 10:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=VQLHFV0OUqaq/f81cJiUYQXPPyfZsSdH372OqxU1a1M=; b=faTY+1aP6E8SCOCOAz732I+oyychCb8sRmOywq9bkPIgG2fo5r9PrNCefWXQ+ntesY mkJg83Kn/yz/vi4W6GFcOmTELbSJBDQXusCsGXGdSF1MZAeZnFzmLW7UvuWqY/c/+Ce8 o48ZpvBVI3ElRVrguKDHhEMLbSXXkrkVarD3GOp/h+k+rLaRoq89PZOsBieONPdYuQLZ 0/nTuoYBlF9Ei5rBqGKcm82kh6a0nmk7w1I6OPpA1Qd7IuQR6kEh6ZreKPeftXcEw2Yr Bka99gACASMSUHXPrFgoCqU7pX2xDp7rYUgnD+SFCxisnVouHJmv3e348idsIH9YL5Yd TaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=VQLHFV0OUqaq/f81cJiUYQXPPyfZsSdH372OqxU1a1M=; b=udUBt6SD9y7XteZ2yvPoeXzpjUF30ql8vj1iXEyidvbPT56DaCce4Kjm3gYUEbrTvq lwqCRHYddIzkVZWXdY+0+c2DzPtuMYY6YT4MCBWrzJIi45MEVc50aMR+T/5LFm0yXJrk roNngt9EJiEV6yGbcxnqzfLy2ca019IIRnCEzpf/DrDWNacl+aPWa2o0jy5AQDfQ+REE i+evh236Xz6gPsMaTblduuRVCAVXnspIqY4ugIe4UDjVHaAeSDgDbqlQBC4xAiZngqzq ZCIGFQybsP+FKeqtKwuDFTBfz6NitrTpwYcaT2LkAcMgTod3zK8LShfxGWDz8iEH8/6S peLQ== X-Gm-Message-State: APjAAAWr/5NylzEIt6/Dbxe/rQXw1sgFPy9VbMvEB8iWQHpnzSAeBisE lhX+EiXRCTRhCIMZfW/hvRkAr6vfm44= X-Google-Smtp-Source: APXvYqzFPhGrcEubNlQNlGCCLjg0AZFLzjeOlxDm7OvJRVu48l5bdcNN6Q56G6Y1M/cQLQm8nzufxg== X-Received: by 2002:a63:360c:: with SMTP id d12mr19797786pga.404.1555954918127; Mon, 22 Apr 2019 10:41:58 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id b15sm24233482pgg.90.2019.04.22.10.41.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 10:41:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: svn commit: r346492 - projects/runtime-coverage-v2/lib/libclang_rt From: Enji Cooper In-Reply-To: Date: Mon, 22 Apr 2019 10:41:56 -0700 Cc: Enji Cooper , src-committers , svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904211926.x3LJQeg2024873@repo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3445.104.8) X-Rspamd-Queue-Id: DB2D66EC46 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 17:42:00 -0000 > On Apr 22, 2019, at 9:22 AM, John Baldwin wrote: >=20 > On 4/21/19 12:26 PM, Enji Cooper wrote: >> Author: ngie >> Date: Sun Apr 21 19:26:40 2019 >> New Revision: 346492 >> URL: https://svnweb.freebsd.org/changeset/base/346492 >>=20 >> Log: >> Build libclang_rt/profile on all clang-supported architectures >>=20 >> There's no reason why a special case needs to be added specifically = for amd64, >> arm, and i386, as the code is written in machine architecture = agnostic C/C++. >>=20 >> There might be compilation/link time issues, but we'll find out = soon. >=20 > For a sanitizer to be useful, you need to make sure clang's FreeBSD = driver > will actually use it. clang has builtin knowledge about which = sanitizers > work on which architectures. Just building the library alone doesn't = enable > it unless you also check the driver in clang. I haven't looked to see = what > conditions clang places on the profile case, but I am familiar with = this > from working on ASAN support for mips. Totally agree. What you=E2=80=99re referring to deals more with = ASAN/MSAN/TSAN, not profile, which is gcov-compatible profiling where = counters are incremented for lines hit and used in analysis tools like = coverity/lcov. gcov can be implemented in machine architecture = independent code. Cheers! -Enji=