From nobody Sat Apr 26 19:21:49 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZlKMd4byyz5tfMn; Sat, 26 Apr 2025 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZlKMd2KGTz3G4Z; Sat, 26 Apr 2025 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745695309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mMT8Lqkjm+ntsCumpEFDLUJnhoR9S8Oflw/p3NV2wQg=; b=gF/T7hIlQKt3CTkbCSzO33z629XoBEX6F9DGet8sSHPspqKn9PnbxWE//nyTiY3R5y2dwo dDV1yVhQLkly6nUBwcUhkueOe5mOLRRkyjtg0Jov5BJYcMXw5AT1Um6GUNPcoEAgrHP8E0 7cbggOib3wUaOhBpd+7f16nvLq/IOB3wCwiGeZcO9y6FwrwA9VO70hF8b6VMcVnSZ0OHaC dJ7gTFYrxxpgVCDJuR6KXOMluj39kh/AnrXqEzur0Lxe1RzRuNQCS/QRbGA+k78zE6MEqJ tPIJWg2n164zjbU/wmDHS92FZytsKbRD+BAYry/6msMwbZa/LCLPlqCyHfaUXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745695309; a=rsa-sha256; cv=none; b=clzHxRH9dWzCQR9A/LOgwNvUPr28gYLzULVW2HaD+laxMfltL1FjlFmxJNShdUoLF3ZbHp jbKXc6fVWSFS839DOUU90ANH59/4+kOJSg4vGz+p9S8BkKVUea+/BI7/cWESGF9u/kbGKa bCjwNS8D9fHeY9U5SKplIc5ipjNFy0hCKVW/FHOCk62GYurPATey4n3CNL7xA3393w4+wh Tqn/931DyUdkBN3S1U3SXDJwdBHOHk9F78NY3kGZQ+uCb6AjXGNuhZuAqB+yn8t7buLC2v kcO4OIUqohqhDeo0+ciUWyWIpyvgqS1CJQ/ouq/Y9cRq/KKPDSOq9ooHhJse2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745695309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mMT8Lqkjm+ntsCumpEFDLUJnhoR9S8Oflw/p3NV2wQg=; b=oTTPOjgYHA8zGcTRFclLxM3GIuVMWlxuLLTD/2RHfL9yLs07/0n5D8zge3ikyi9T7/3hul 4r4baBM9D4jUuVd8C0iMxcnbXaZGbDpbmuwT1m16g5XIuTrdIjHE6VpjoCQwlWHqCnHsyf M426vOoeoz1rhzUX8vSCGtG5SxJkkwtzdyrGebczl0SkHpJDW+wmRg25fAlLt3xUpXzrya Con3N9/N7RG3BpREP/dxVYrMYbLxyby1rKYQ30ywi4/Z3jgmwHdLRC/g80d2Q3AU6ZR1d2 z/GxqiukJ27HbUj6nqrcHIsXXiplPqK61Wuv8r4QcjCEEvzIdSejQusbN8y7Hw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZlKMd1jhvzYr9; Sat, 26 Apr 2025 19:21:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53QJLnnq009628; Sat, 26 Apr 2025 19:21:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53QJLnPm009625; Sat, 26 Apr 2025 19:21:49 GMT (envelope-from git) Date: Sat, 26 Apr 2025 19:21:49 GMT Message-Id: <202504261921.53QJLnPm009625@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 66d36f4f1025 - stable/14 - Turn off hw.pci.intx_reroute in EC2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 66d36f4f1025193a64cf296873ed4a4b34471d91 Auto-Submitted: auto-generated The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=66d36f4f1025193a64cf296873ed4a4b34471d91 commit 66d36f4f1025193a64cf296873ed4a4b34471d91 Author: Colin Percival AuthorDate: 2025-04-23 15:17:51 +0000 Commit: Colin Percival CommitDate: 2025-04-26 19:21:22 +0000 Turn off hw.pci.intx_reroute in EC2 Having this enabled on Graviton systems prior to Graviton 4 results in a resource leak and a kernel panic after repeated hotplug/unplug. MFC after: 3 days Sponsored by: Amazon (cherry picked from commit ce9a34b1614e37dc3f8763586448063408c7bf16) --- release/tools/ec2.conf | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf index 2856068459c3..1116faed4e9c 100644 --- a/release/tools/ec2.conf +++ b/release/tools/ec2.conf @@ -72,6 +72,12 @@ ec2_common() { # delay before rescanning upon device detach. echo 'debug.acpi.quirks="56"' >> ${DESTDIR}/boot/loader.conf + # The default behaviour of re-routing INTx interrupts causes a + # resource leak on INTRng (aka on Graviton systems). Repeated + # hotplug/unplug on PCI (not PCIe) Graviton systems ends up with + # a kernel panic unless we disable this. + echo 'hw.pci.intx_reroute=0' >> ${DESTDIR}/boot/loader.conf + # Load the kernel module for the Amazon "Elastic Network Adapter" echo 'if_ena_load="YES"' >> ${DESTDIR}/boot/loader.conf