From owner-svn-ports-all@FreeBSD.ORG Thu Jul 11 13:03:07 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D2519C3B; Thu, 11 Jul 2013 13:03:07 +0000 (UTC) (envelope-from william88@gmail.com) Received: from mail-lb0-x22c.google.com (mail-lb0-x22c.google.com [IPv6:2a00:1450:4010:c04::22c]) by mx1.freebsd.org (Postfix) with ESMTP id 965811C01; Thu, 11 Jul 2013 13:03:06 +0000 (UTC) Received: by mail-lb0-f172.google.com with SMTP id v20so6686419lbc.3 for ; Thu, 11 Jul 2013 06:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ZPrsD7h5tBMKssJPreVXUyYEAj3yshPCgxsVHXB6p9k=; b=WvSA7TI2qyp7Lpzx1Tc4wHx0q0zmAPepxSWeXAXTzmHHUd4Q8Rl57HOGb7U+7QjxqC 3m5OmUJ1jEykiOJv2FawR4xBW2dG/oZJ4cNdtHGTES2eWIq9wsLHmLM+0tEkYGO3FyJ0 5tYbwb8TFlfH9w0ea6CzSaZGhjsh8163uQtKkwIMAWL/11t7cKf1srvrYJLnT8hjqS5r DZaNgdsgbwtdioNqdQ5j5GYIbfWQgpSZLpOFAAiitgTNaZqFIbvA9Qm24fAUKQERfEeC AmvGcxhuGiSy3XdqG9xbDyphFBLO0+AQv2Bfv49WKJxWfoB9Od/5XRdQix61u1yaNBdn LCQQ== MIME-Version: 1.0 X-Received: by 10.112.135.99 with SMTP id pr3mr16986929lbb.23.1373547785573; Thu, 11 Jul 2013 06:03:05 -0700 (PDT) Received: by 10.114.91.164 with HTTP; Thu, 11 Jul 2013 06:03:05 -0700 (PDT) In-Reply-To: <20130711125532.GA72196@FreeBSD.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org> <20130711125532.GA72196@FreeBSD.org> Date: Thu, 11 Jul 2013 10:03:05 -0300 Message-ID: Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent From: William Grzybowski To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski , ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 13:03:07 -0000 On Thu, Jul 11, 2013 at 9:55 AM, Alexey Dokuchaev wrote: > On Thu, Jul 11, 2013 at 08:42:23AM -0300, William Grzybowski wrote: >> On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev wrote: >> > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote: >> >> New Revision: 322724 >> >> URL: http://svnweb.freebsd.org/changeset/ports/322724 >> >> >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-qt-dbus >> >> .endif >> >> >> >> post-patch: >> >> - @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp >> >> + @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp >> > >> > There are two problems with this part: >> > [...] >> >> It would make everyones life easier if you had put a comment in the >> post-patch line about that fact. > > True; usually I document any REINPLACE_CMD which might be confusing to > others, in this case I thought it's kinda self-explanatory. The point > is that 1) many porters/comitters do not document these things, and it > might happen to anyone else; 2) regardless of the presence of comment, > or lack thereof, anyone who is updating the port should recheck if any > previous patch(es) are still valid. This was obviously not done here. Point taken, twice, and I appreciate your comments, I screwed up. How long should I knee in grains of corn? ;) -- William Grzybowski ------------------------------------------ Curitiba/PR - Brasil