From owner-svn-src-head@FreeBSD.ORG Mon Apr 29 14:50:07 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B4188135; Mon, 29 Apr 2013 14:50:07 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-ve0-x22a.google.com (mail-ve0-x22a.google.com [IPv6:2607:f8b0:400c:c01::22a]) by mx1.freebsd.org (Postfix) with ESMTP id 4278A1910; Mon, 29 Apr 2013 14:50:07 +0000 (UTC) Received: by mail-ve0-f170.google.com with SMTP id 15so3117206vea.15 for ; Mon, 29 Apr 2013 07:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=OfPyEZK7mm6QI9BBIy4/Y2X3LpPG8C6C9yOP1sLlrEM=; b=V0b6ZB3Ec+qXShPFsOkd2AE2NjqMSuMwwPgx0m41/BExKobS+qNoLaD3h6klqqOGEj Qq2Cslz9+BFN5Dj0HszPpHK+MJpuNosbNxQRYHVtoL4KccIB47uqI2hGr2a9prJWg8v9 bPZNzSPnjZnzNKi/6eVyCitu/l1aDGk9TL11DslTxomgvOE0J13t+cyBrs/nZUGtTqKk kud1HscJ0FK5OMQutFVNXsz6vxZyCTooU0BJhzt7QwC32ncYXYUxBHeuZgNKVZiZpblF ZA+C79NRb6IWhcenAB80cC4iSAy3ZkOSYWlFCoIVbqe0kWndUDIVs4M0nuiNnhP4YEdQ QRaA== MIME-Version: 1.0 X-Received: by 10.52.25.40 with SMTP id z8mr2505636vdf.7.1367247006856; Mon, 29 Apr 2013 07:50:06 -0700 (PDT) Sender: edschouten@gmail.com Received: by 10.221.10.69 with HTTP; Mon, 29 Apr 2013 07:50:06 -0700 (PDT) In-Reply-To: <20130429212227.R1043@besplex.bde.org> References: <201304282252.r3SMqiHH009205@svn.freebsd.org> <20130429212227.R1043@besplex.bde.org> Date: Mon, 29 Apr 2013 16:50:06 +0200 X-Google-Sender-Auth: 3OF8JXFfBI8914SpnbFljOfw52E Message-ID: Subject: Re: svn commit: r250037 - head/bin/hostname From: Ed Schouten To: Bruce Evans Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2013 14:50:07 -0000 Hi Bruce, 2013/4/29 Bruce Evans : > - usr.bin/rlogin/rlogin.c has it in a gratuitously different form, as > 'static _Noreturn void usage(void);'. This is bogus since > _Noreturn is a wrapper for a new C++ feature I hate to correct you here, but _Noreturn is not a wrapper for a new C++ feature, it's a keyword that's part of C11. See: http://en.wikipedia.org/wiki/C11_(C_standard_revision)#Changes_from_C99 All C11 keywords can be implemented on top of GCC-specific constructs, with the exception of _Generic. I would strongly prefer it if we used these keywords over our FreeBSD-specific solutions. If the only objection is the spelling of these keywords (underscores, uppercase, etc), be sure to: #include /* For alignas/alignof. */ #include /* For noreturn. */ #include /* For thread_local. */ -- Ed Schouten