From owner-cvs-all@FreeBSD.ORG  Sat Nov 27 18:54:48 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 959FA16A4CE; Sat, 27 Nov 2004 18:54:48 +0000 (GMT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0C80343D45; Sat, 27 Nov 2004 18:54:48 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iARIw2Ao093637;
	Sat, 27 Nov 2004 11:58:03 -0700 (MST)
	(envelope-from scottl@freebsd.org)
Message-ID: <41A8CD95.3050005@freebsd.org>
Date: Sat, 27 Nov 2004 11:55:17 -0700
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Nate Lawson <nate@root.org>
References: <20041127114337.95FC716A4EE@hub.freebsd.org>
	<41A8C429.1090406@root.org>
In-Reply-To: <41A8C429.1090406@root.org>
X-Enigmail-Version: 0.86.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: David Xu <davidxu@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_synch.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Nov 2004 18:54:48 -0000

Nate Lawson wrote:
> David Xu wrote:
> 
>> davidxu     2004-11-27 11:43:31 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/kern             kern_synch.c   Log:
>>   Unlock mutex if PDROP was set by caller.
>>     Revision  Changes    Path
>>   1.265     +2 -0      src/sys/kern/kern_synch.c
>>
>>
>> Index: src/sys/kern/kern_synch.c
>> diff -u src/sys/kern/kern_synch.c:1.264 src/sys/kern/kern_synch.c:1.265
>> --- src/sys/kern/kern_synch.c:1.264    Sat Oct 16 06:38:22 2004
>> +++ src/sys/kern/kern_synch.c    Sat Nov 27 11:43:31 2004
>> @@ -175,6 +175,8 @@
>>          mtx_unlock_spin(&sched_lock);
>>          if (rval != 0) {
>>              sleepq_release(ident);
>> +            if (mtx != NULL && priority & PDROP)
>> +                mtx_unlock(mtx);
>>              return (rval);
>>          }
>>      }
> 
> 
> Are you serious?  PDROP was unimplemented until now?
> 
> -Nate

No, this just fixes an edge-case that wasn't covered before.

Scott