From owner-svn-src-all@freebsd.org Thu Jan 18 21:04:04 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49DDCEC2FAF for ; Thu, 18 Jan 2018 21:04:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CE47580B20 for ; Thu, 18 Jan 2018 21:04:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-wm0-x230.google.com with SMTP id i186so24468445wmi.4 for ; Thu, 18 Jan 2018 13:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hEXcYrU5aI4w7qicdOtpQ91O+aZFdkbbAzRejRrqWwA=; b=kOT08as5/91ylUXZDuin98LLRj2rlECdQ2tKpP3v0WNO/yhfLHITKFXGWBsMZsh+GM iDdjbKiiQrmQZKoYEJ2YsAnC22bZ4M6OfClY9b8ZRxlsgQP1TF54lLpZE0GYTjQ2uM8A 2kOoYJnAjikgLtLqW7K2CZIHiP0FvoB54NPLgjKLQPhSkihJnzsfmEc7Cgqjv1abyrH+ kg2UdmtT1ecxLhipI4hVXKtP5SOB+Wg7UdR4pBN4XjzB0xr31ZchdDgmgrBCcmLK7k43 xfONG089K1UkaltIyaRUP4FKb461jD07ZxzqlTGbLiiRWB8bw8NDiPyJWtC1Y8p5b4Pk gwAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hEXcYrU5aI4w7qicdOtpQ91O+aZFdkbbAzRejRrqWwA=; b=B/nVmL7TLmJqrgnRqCjun1WWyOEZgIMDrGjCoJv5vDOyR+sXIz1oOxcJOA0nD24oqt BymSfrsYxqt2xk0JEohTBPwuP43owk9sJfyNoiZ9n0S4svl5jrUA4l76YzIXAOAPzmPR nqVxSZHS98P2KP2jiYXzLKCp879hPT1PXtMu0dSvUVOGOxdG9bVeXQL4BRD1QqLy9roo qjgwEFjFsCZwJVLvIuVlaNz1sZ4yz8AP8zi6Hccq+rv/ONvioYQFLZOAoxM9bzkjkzXW 1ayugTP7jBCwyfvH5zsbtCy2PDB1RZ5zpdhxgzE2CCKtG1hiEkYKANyFbgckUp5ByIqQ EK0Q== X-Gm-Message-State: AKwxytddjx2CLIlSCGOtMWxtma6SOle6Z7LQASYbtygmK/486/P2EWXh Gw9Z6RT5Bpn1TotpZO6rKtnYrl3+qqrFnhFiRJ/VLQ== X-Google-Smtp-Source: ACJfBoth+/CVsocGvB8KyoNqXHPEQ6Z+Hp3HSwZ2nYRurgaTyqvRrI1n5wRo6DOqMKy3e5GlrcbqwTpis+N3jG7AKGo= X-Received: by 10.80.147.228 with SMTP id o91mr9990716eda.206.1516309442066; Thu, 18 Jan 2018 13:04:02 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.80.195.12 with HTTP; Thu, 18 Jan 2018 13:04:01 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201712291905.vBTJ57gI072871@repo.freebsd.org> <20180117224054.GO8113@FreeBSD.org> <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net> From: Warner Losh Date: Thu, 18 Jan 2018 14:04:01 -0700 X-Google-Sender-Auth: fSLXfS7ottohE3eNLxGvNK8buro Message-ID: Subject: Re: svn commit: r327354 - head/sys/vm To: "Conrad E. Meyer" Cc: Eric van Gyzen , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 21:04:04 -0000 On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: > On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen > wrote: > > On 01/17/2018 16:40, Gleb Smirnoff wrote: > >> Yeah, style is sacred, but is there a single person on Earth who would > >> not agree that moving variables from smaller blocks to function block > >> reduces readability of the code? > > > > I agree that it reduces the readability. Not only that, it also > > encourages real bugs by allowing access to the variable when it does no= t > > make sense. > > I think the right way to propose this kind of policy change is to get > agreement on how style(9) should be modified =E2=80=94 not arbitrarily go > against style(9) in some files. The proposed change may be somewhat > contentious and it might be a good exercise to go through the FreeBSD > Community Process. > > I might separate these two concerns: > > 1. Allowing local / block scoped variables > 2. Allowing C99 for loop initial declarations > > But I could see the argument that (2) is just a boring subset of (1). > Tell me again where #1/#2 are disallowed? I can't seem to find that in style(9), except by a weak example of there being no examples of #1 or #2. Warner