Date: Fri, 22 Aug 2008 21:27:37 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern tty.c Message-ID: <200808222127.m7MLRjDl060045@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-08-22 21:27:37 UTC
FreeBSD src repository
Modified files:
sys/kern tty.c
Log:
SVN rev 182023 on 2008-08-22 21:27:37Z by ed
Fix two small bugs in tcsetattr().
- According to POSIX, tcsetattr() must not fail when any of the bits in
the structure are unsupported, but it must leave the unsupported flags
alone.
- The CIGNORE flag (set by TCSASOFT, extension) was not cleared from
c_cflag, which means using it would cause it to be applied during its
entire lifespan. Eventually make sure we clear the flag.
I don't really like CIGNORE, but I think we must keep it alive right
now. With our new TTY layer, we don't actually need this mechanism,
because if you leave c_cflag, c_ispeed and c_ospeed alone, we won't make
a call into the device driver anyway.
Reported by: naddy
Tested by: naddy
Revision Changes Path
1.284 +6 -7 src/sys/kern/tty.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808222127.m7MLRjDl060045>