From owner-svn-src-all@freebsd.org Fri Nov 20 14:37:08 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 82C652EC549; Fri, 20 Nov 2020 14:37:08 +0000 (UTC) (envelope-from 0mp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cczdw3HRQz3jV2; Fri, 20 Nov 2020 14:37:08 +0000 (UTC) (envelope-from 0mp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 639C3171FF; Fri, 20 Nov 2020 14:37:08 +0000 (UTC) (envelope-from 0mp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AKEb8vw007675; Fri, 20 Nov 2020 14:37:08 GMT (envelope-from 0mp@FreeBSD.org) Received: (from 0mp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0AKEb8r0007674; Fri, 20 Nov 2020 14:37:08 GMT (envelope-from 0mp@FreeBSD.org) Message-Id: <202011201437.0AKEb8r0007674@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: 0mp set sender to 0mp@FreeBSD.org using -f From: Mateusz Piotrowski <0mp@FreeBSD.org> Date: Fri, 20 Nov 2020 14:37:08 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367893 - head/libexec/rc/rc.d X-SVN-Group: head X-SVN-Commit-Author: 0mp X-SVN-Commit-Paths: head/libexec/rc/rc.d X-SVN-Commit-Revision: 367893 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2020 14:37:08 -0000 Author: 0mp (doc,ports committer) Date: Fri Nov 20 14:37:07 2020 New Revision: 367893 URL: https://svnweb.freebsd.org/changeset/base/367893 Log: Revert r367291 (KEYWORD: shutdown for rc.d/zfs) The problem is that zfs is asked to stop too early in the shutdown sequence. Other services, such as syslog may still be running and have some files open (e.g., under /var/log). This of course causes the messages like: cannot unmount '/var/run': umount failed cannot unmount '/var/log': umount failed cannot unmount '/var': umount failed cannot unmount '/usr/home': umount failed cannot unmount '/usr': umount failed cannot unmount '/': umount failed For now, let's remove the shutdown KEYWORD from the zfs service, as people are reporting problems in their setups: https://lists.freebsd.org/pipermail/freebsd-current/2020-November/077559.html In the future, we may think of stopping zfs on shutdown after all the other services and just before init(8) exits. Another interesting option might be to a new rcorder(8) KEYWORD like "shutdownjail", but this idea would need to be discussed a bit. Reported by: Johan Hendriks Reported by: Yasuhiro KIMURA Reported by: Tomoaki AOKI Approved by: kevans (src) MFC: 3 days Differential Revision: https://reviews.freebsd.org/D27263 Modified: head/libexec/rc/rc.d/zfs Modified: head/libexec/rc/rc.d/zfs ============================================================================== --- head/libexec/rc/rc.d/zfs Fri Nov 20 14:02:43 2020 (r367892) +++ head/libexec/rc/rc.d/zfs Fri Nov 20 14:37:07 2020 (r367893) @@ -6,7 +6,6 @@ # PROVIDE: zfs # REQUIRE: zfsbe # BEFORE: FILESYSTEMS var -# KEYWORD: shutdown . /etc/rc.subr