From owner-svn-ports-head@FreeBSD.ORG Thu Jul 11 12:50:01 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E7CA5459; Thu, 11 Jul 2013 12:50:01 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40]) by mx1.freebsd.org (Postfix) with ESMTP id CB8E61B18; Thu, 11 Jul 2013 12:50:01 +0000 (UTC) Received: by mail.soaustin.net (Postfix, from userid 502) id A8A235606D; Thu, 11 Jul 2013 07:50:00 -0500 (CDT) Date: Thu, 11 Jul 2013 07:50:00 -0500 From: Mark Linimon To: Alexey Dokuchaev Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent Message-ID: <20130711125000.GA31005@lonesome.com> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130711054533.GA70334@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 12:50:02 -0000 On Thu, Jul 11, 2013 at 05:45:33AM +0000, Alexey Dokuchaev wrote: > 1) It gratuitously changes perfectly fine commas to (also perfectly fine > as it might seem) bars. Gratuitous commits should generally be avoided, as > they decrease STN ratio, and most importantly, they break 'svn blame'; This is exactly how I feel about non-code changes (e.g. whitespace, headers, formatting), and why I am in general against sweeps to implement such changes. mcl