Date: Thu, 24 May 2018 12:57:50 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: "Tobias C. Berner" <tcberner@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Tobias Kortkamp <tobik@freebsd.org>, Fernando =?iso-8859-1?Q?Apestegu=EDa?= <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files Message-ID: <20180524105750.tw2vl4v3trg3jhiv@ogg.in.absolight.net> In-Reply-To: <CAOshKtdixfdPFKyWJst%2BaW4cT_uEYmhc6Adpb3xEVFWWYFaL1A@mail.gmail.com> References: <201805232159.w4NLxYrK000782@repo.freebsd.org> <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> <CAOshKtdixfdPFKyWJst%2BaW4cT_uEYmhc6Adpb3xEVFWWYFaL1A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--abcwcyhsqdilujzl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 24, 2018 at 12:43:57PM +0200, Tobias C. Berner wrote: > That was what I suggested initially. >=20 > But as you commented on the target used to install the file without also > weighing in on the issue of adding binaries, I assumed it was fine :) I cannot see everything, and most of the times, when my focus catches on a big mistake, like the two targets, it usually means the Makefile has larger structural problems that needs addressed first, so I do not delve too much on what goes on. When the Makefile looks saner, and a quick glance cannot find anything blatantly wrong, I look deeper into things. But in any way, I am human, and I miss stuff. > mfg Tobias >=20 > On 24 May 2018 at 08:55, Mathieu Arnold <mat@freebsd.org> wrote: >=20 > > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote: > > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have > > > binary files in files/*.png. Can we add new ones or is it forbidden > > now? > > > It seems weird to have to base64 encode icons and decode them duri= ng > > the > > > build. > > > > I think it would be better to keep binary files out of the ports tree. > > It's probably as easy to drop them in LOCAL/user, either individually or > > in an archive. > > > > -- > > Mathieu Arnold > > --=20 Mathieu Arnold --abcwcyhsqdilujzl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbBpquXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IiEwQAIHGN6mI+E3CR57B7xEKJKvP tgshzp2wotNGtghZLP2wXQvbdn5+vzhxWgH41hf08RzxZQq9aLHjDrsJtcOkHLly ECtKPB8fsca6VeNhx5VCfejXiLlmhw6C80qgjWNbRfHVaAAmYOVxMX2OAjNdwGEa zmdxqt3rp7LV15wYWWEQVmnBSdJ+k+8vpKrGh2YUFu20SK6GPeaBPG+QM3vlh9hq aX8KoDWCJH8H3giiqheG1Mp9ekwVrF3V/CKcMrAgjN6vCJYaM5EF1pyQzXsRxSyf 1/tqwN/B5KX61KU5at2zztGgPqvLIu2P9XsnPJD/REq7rzcKJ+kk6rufz/OW4RQQ N5LnkoTf16IQlTYyh3Pccy8b5Ecrb6GuVH1oOww5Y3ipK5+0rxD+iwvDR5mRNp5e B7k+SJ9BqZJIFR70DXqeqmN0ClbiXz2/s7a/dIO3aoIWous7zhHQEL1eqUJaTcyz Q8bKdPfPgKHlHBs1WYgfnCgVutSD/MgOy6SFlP1g4NRSy1lfORGiG2pgDqB9YCIA ZrJHn7GzB8o20iUR1TgemTeZQPKSd47WwNca96reJ+R5mLbdWEaQNo1vEBeLLBs2 LFNMNkhKVn2BJ2aK4lSmLoEu5MzAzGbN9Go716+irZ2pt8mYDMcf92/LmNdapX76 qWhBdMmOPFVKyvIYmeU4 =cL2K -----END PGP SIGNATURE----- --abcwcyhsqdilujzl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180524105750.tw2vl4v3trg3jhiv>