From owner-svn-ports-head@freebsd.org Thu May 24 10:57:53 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 777A1EB1471; Thu, 24 May 2018 10:57:53 +0000 (UTC) (envelope-from m@absolight.fr) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "prod2.absolight.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ECD1183C74; Thu, 24 May 2018 10:57:52 +0000 (UTC) (envelope-from m@absolight.fr) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id A2A3ABDC89; Thu, 24 May 2018 12:57:51 +0200 (CEST) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 85538BDC85; Thu, 24 May 2018 12:57:51 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id 00EFE6167; Thu, 24 May 2018 12:57:50 +0200 (CEST) Received: by ogg.in.absolight.net (Postfix, from userid 501) id A69566BD6ED2; Thu, 24 May 2018 12:57:50 +0200 (CEST) Date: Thu, 24 May 2018 12:57:50 +0200 From: Mathieu Arnold To: "Tobias C. Berner" Cc: Mathieu Arnold , Tobias Kortkamp , Fernando =?iso-8859-1?Q?Apestegu=EDa?= , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files Message-ID: <20180524105750.tw2vl4v3trg3jhiv@ogg.in.absolight.net> References: <201805232159.w4NLxYrK000782@repo.freebsd.org> <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> <20180524065529.rtcmylbz5qtnupnx@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="abcwcyhsqdilujzl" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 10:57:53 -0000 --abcwcyhsqdilujzl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 24, 2018 at 12:43:57PM +0200, Tobias C. Berner wrote: > That was what I suggested initially. >=20 > But as you commented on the target used to install the file without also > weighing in on the issue of adding binaries, I assumed it was fine :) I cannot see everything, and most of the times, when my focus catches on a big mistake, like the two targets, it usually means the Makefile has larger structural problems that needs addressed first, so I do not delve too much on what goes on. When the Makefile looks saner, and a quick glance cannot find anything blatantly wrong, I look deeper into things. But in any way, I am human, and I miss stuff. > mfg Tobias >=20 > On 24 May 2018 at 08:55, Mathieu Arnold wrote: >=20 > > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote: > > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have > > > binary files in files/*.png. Can we add new ones or is it forbidden > > now? > > > It seems weird to have to base64 encode icons and decode them duri= ng > > the > > > build. > > > > I think it would be better to keep binary files out of the ports tree. > > It's probably as easy to drop them in LOCAL/user, either individually or > > in an archive. > > > > -- > > Mathieu Arnold > > --=20 Mathieu Arnold --abcwcyhsqdilujzl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbBpquXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IiEwQAIHGN6mI+E3CR57B7xEKJKvP tgshzp2wotNGtghZLP2wXQvbdn5+vzhxWgH41hf08RzxZQq9aLHjDrsJtcOkHLly ECtKPB8fsca6VeNhx5VCfejXiLlmhw6C80qgjWNbRfHVaAAmYOVxMX2OAjNdwGEa zmdxqt3rp7LV15wYWWEQVmnBSdJ+k+8vpKrGh2YUFu20SK6GPeaBPG+QM3vlh9hq aX8KoDWCJH8H3giiqheG1Mp9ekwVrF3V/CKcMrAgjN6vCJYaM5EF1pyQzXsRxSyf 1/tqwN/B5KX61KU5at2zztGgPqvLIu2P9XsnPJD/REq7rzcKJ+kk6rufz/OW4RQQ N5LnkoTf16IQlTYyh3Pccy8b5Ecrb6GuVH1oOww5Y3ipK5+0rxD+iwvDR5mRNp5e B7k+SJ9BqZJIFR70DXqeqmN0ClbiXz2/s7a/dIO3aoIWous7zhHQEL1eqUJaTcyz Q8bKdPfPgKHlHBs1WYgfnCgVutSD/MgOy6SFlP1g4NRSy1lfORGiG2pgDqB9YCIA ZrJHn7GzB8o20iUR1TgemTeZQPKSd47WwNca96reJ+R5mLbdWEaQNo1vEBeLLBs2 LFNMNkhKVn2BJ2aK4lSmLoEu5MzAzGbN9Go716+irZ2pt8mYDMcf92/LmNdapX76 qWhBdMmOPFVKyvIYmeU4 =cL2K -----END PGP SIGNATURE----- --abcwcyhsqdilujzl--