From owner-freebsd-current@FreeBSD.ORG  Sun Jun 27 17:40:43 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CD06716A4CE; Sun, 27 Jun 2004 17:40:43 +0000 (GMT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4353943D1D; Sun, 27 Jun 2004 17:40:43 +0000 (GMT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 90B25ACAE3; Sun, 27 Jun 2004 19:40:40 +0200 (CEST)
Date: Sun, 27 Jun 2004 19:40:40 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Message-ID: <20040627174040.GM12007@darkness.comp.waw.pl>
References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org>
	<20040627065932.GH12007@darkness.comp.waw.pl>
	<20040627101951.GJ12007@darkness.comp.waw.pl>
	<Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net>
	<20040627160959.GL12007@darkness.comp.waw.pl>
	<Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="CVsfbEDr348T3/Se"
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.53.0406271706340.89503@e0-0.zab2.int.zabbadoz.net>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: Robert Watson <rwatson@freebsd.org>
cc: Julian Elischer <julian@elischer.org>
cc: "Bjoern A. Zeeb" <bzeeb+freebsd@zabbadoz.net>
cc: FreeBSD current users <current@freebsd.org>
Subject: Re: jail getfsstat patches.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jun 2004 17:40:44 -0000


--CVsfbEDr348T3/Se
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 27, 2004 at 05:29:23PM +0000, Bjoern A. Zeeb wrote:
+> some more points while skipping through the code a second time:
+>=20
+> * could we make this
+> 	strlcpy(sp->f_mntonname, "<restricted>",
+>   s.th. w/o '<' and '>' ? [] or () would make me feel better as
+>   those though special characters won't redirect anything in sh
+>   even if we should never see this.

Ok, will do.

+> * in fhstatfs you missed a prison_enforce_statfs call

Nope. It is placed in cvtstatfs().

+> * some spelling/grammer left to someone else

Yeah.

+> else looks good to me; didn't check the compat code;
+> going to see if I can build a kernel and setup some jails on a
+> test machine to see if it works as well.

Thanks!

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--CVsfbEDr348T3/Se
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFA3waYForvXbEpPzQRAtbTAKDDoQRnpLkqmXD5908ahCzzatO/gwCeMs64
u0FquFJToNV0L75C75CMWrM=
=1I92
-----END PGP SIGNATURE-----

--CVsfbEDr348T3/Se--