From owner-svn-src-all@FreeBSD.ORG Wed Jun 10 09:17:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA46A106564A; Wed, 10 Jun 2009 09:17:16 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) by mx1.freebsd.org (Postfix) with ESMTP id 70F6C8FC08; Wed, 10 Jun 2009 09:17:16 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id n5A9HF2Z004994; Wed, 10 Jun 2009 13:17:15 +0400 (MSD) (envelope-from marck@rinet.ru) Date: Wed, 10 Jun 2009 13:17:15 +0400 (MSD) From: Dmitry Morozovsky To: Kip Macy In-Reply-To: <200906100121.n5A1LWVO089719@svn.freebsd.org> Message-ID: References: <200906100121.n5A1LWVO089719@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (woozle.rinet.ru [0.0.0.0]); Wed, 10 Jun 2009 13:17:15 +0400 (MSD) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 09:17:17 -0000 On Wed, 10 Jun 2009, Kip Macy wrote: KM> + if ((((uint64_t)physmem * PAGESIZE) < (1ULL << 32)) && KM> + (zfs_prefetch_enable != 1) && (zfs_prefetch_disable != 1)) { KM> + printf("ZFS NOTICE: system has less than 4GB and prefetch enable is not set" KM> + "... disabling.\n"); KM> + zfs_prefetch_disable=1; KM> + } Also: this will disable prefetch on a system with exact 4G of memory *and* some subsystem which allocates memory from system (e.g., integrated video) Don't you think the threshold like 3G would be more appropriate? -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------