From owner-svn-src-all@FreeBSD.ORG Thu Feb 12 23:14:01 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7923391A for ; Thu, 12 Feb 2015 23:14:01 +0000 (UTC) Received: from nm25-vm1.bullet.mail.bf1.yahoo.com (nm25-vm1.bullet.mail.bf1.yahoo.com [98.139.212.155]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D778C2C for ; Thu, 12 Feb 2015 23:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1423782833; bh=XYgtnwpxqbZxGkQUuEsQje6PfmwZVJD1W/dfPZ0G5lM=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=QGTaOAX8ajrbLrjNCVFKlO4IMBrXER75bz9au/hN7QDCdgs/o7Lz3Ym4GYl4icddZ5NPtCTbcdF/dQtH6cux/cFtpd7fH1k3Zyr3Tj4w8KWd/1P9owyHWBwd3po/c4hfatkn5U0atUJiKQttaMojdtghFkbHYkNhh+Q7N6GnV/eC84BoqcI8RSda7bqMfRpZJQNqYJaDqp+Pk2fWpgHePVLpPeVD7ci3kNvJew8X/UwzJ3kvDORQkDKhq4/CCNAJ/rno+eL5DR6diVR2OT1Yf/Mcrn98GlLt7502KdBi50klsB2hsSVnDKD83YObAusFfSREsOmetk8qKKTxJizqJg== Received: from [66.196.81.171] by nm25.bullet.mail.bf1.yahoo.com with NNFMP; 12 Feb 2015 23:13:53 -0000 Received: from [98.139.213.15] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 12 Feb 2015 23:13:53 -0000 Received: from [127.0.0.1] by smtp115.mail.bf1.yahoo.com with NNFMP; 12 Feb 2015 23:13:53 -0000 X-Yahoo-Newman-Id: 294654.33387.bm@smtp115.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: lyhNNCgVM1lO.1UYedRSOCxDz73sDM1x3UdfPhpNxYSc7iz eQjYqG2p..4plhOL3TaiyP1VMfVcjWbZxD5w0Air8lofGRyS52fte6MeR6qW eDU8_UtkYvbBJ2jzElVbTp3mah8ruhzN1CYbM2c2gLaJdA2Hz4B6POebxaH8 iWnwQEubbDEXNMPwEDZu1bzGG_4rKGYZxz23r4bfgnZBFklVNd92VYdDZnpB WlB5spUiluGzkpXL81suoeA3MhjOQXR3jZz_Ecp.TX2KvN1BXPXBZ8NjY2sQ NtcmbcYPGN.b_Irgk_R9bKGwbBmPpuY5M752mHnszCpsxDtH94dGMsB9.B8m IlSEpu1vaqfqIZaeMAXcokL6DMWf_KCiVuMFjr6o1.HEDf0iKsdMcYsQ4tTB XxRScpwWnWnKHOkz0bjSp.xfWRxw93V41AY8f4za7W.HDpIusoe344PddDyf X0P3A.Ps6D3Y.JFUUDiSUxEGCtTSedyUc6wr3X8.upO3UVNWmoKJ2rrltFPY Iq_t9jaYnem0HkUuWXLQWfq3kvig9pJoEci2LB_rjF7ZBc.wSxh1bKFffl.B PznO1lpvrSlNOeNmaP6k6eg-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <54DD33B9.3000804@FreeBSD.org> Date: Thu, 12 Feb 2015 18:14:01 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Bjoern A. Zeeb" Subject: Re: svn commit: r278634 - head/lib/libc/gen References: <201502122107.t1CL7gaO004041@svn.freebsd.org> <54DD2A87.2050008@FreeBSD.org> <9A683D99-C1E9-4736-982C-69F583D3A40D@FreeBSD.org> In-Reply-To: <9A683D99-C1E9-4736-982C-69F583D3A40D@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 23:14:01 -0000 On 02/12/15 17:44, Bjoern A. Zeeb wrote: >> On 12 Feb 2015, at 22:34 , Pedro Giffuni wrote: >> >> >> On 02/12/15 17:27, Bjoern A. Zeeb wrote: >>>> On 12 Feb 2015, at 21:07 , Pedro F. Giffuni wrote: >>>> >>>> Author: pfg >>>> Date: Thu Feb 12 21:07:42 2015 >>>> New Revision: 278634 >>>> URL: https://svnweb.freebsd.org/changeset/base/278634 >>>> >>>> Log: >>>> ulimit(3): Fix broken check. >>>> >>>> The existing implementation had a broken comparison that could overflow. >>>> Replace this with a check that avoids the overflow before it happens. >>>> >>>> Consistently return a maximum value also on the case of negative >>>> arguments since negative is considered an overflow and means >>>> infinity for our current setrlimit(). >>>> >>>> Discussed with: bde (rather extensively) >>>> >>> Did this compile? >>> >> Yes! Any log message to share? > Now I do again; had lost them due to buildworld starting over again: > > ===> lib/libc_nonshared (obj,depend,all,install) > cc1: warnings being treated as errors > /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c: In function 'ulimit': > /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:56: warning: comparison is always false due to limited range of data type > /scratch/tmp/bz/head.svn/lib/libc/gen/ulimit.c:57: warning: overflow in implicit constant conversion > --- ulimit.So --- > *** [ulimit.So] Error code 1 > > > mips.mipsn32 buildworld failed, check _.mips.mipsn32.buildworld for details > mips.mips buildworld failed, check _.mips.mips.buildworld for details > powerpc.powerpc buildworld failed, check _.powerpc.powerpc.buildworld for details > mips.mipsel buildworld failed, check _.mips.mipsel.buildworld for details > arm.armeb buildworld failed, check _.arm.armeb.buildworld for details > arm.armv6hf buildworld failed, check _.arm.armv6hf.buildworld for details > arm.arm buildworld failed, check _.arm.arm.buildworld for details > arm.armv6 buildworld failed, check _.arm.armv6.buildworld for details > pc98.i386 buildworld failed, check _.pc98.i386.buildworld for details > i386.i386 buildworld failed, check _.i386.i386.buildworld for details > powerpc.powerpc64 buildworld failed, check _.powerpc.powerpc64.buildworld for details > amd64.amd64 buildworld failed, check _.amd64.amd64.buildworld for details > > Thank you! This will sound strange but I can't confirm, and I can't see anything obviously wrong. I have the revert ready but let me wait for jenkins to catch the failure first. Pedro.