From owner-cvs-all@FreeBSD.ORG Thu May 4 19:25:14 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09A0A16A464; Thu, 4 May 2006 19:25:14 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 308E543D67; Thu, 4 May 2006 19:25:12 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 99B651FFADC; Thu, 4 May 2006 21:25:11 +0200 (CEST) Received: by transport.cksoft.de (Postfix, from userid 66) id 147C01FFAD3; Thu, 4 May 2006 21:25:08 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id E2FC94448D6; Thu, 4 May 2006 19:24:07 +0000 (UTC) Date: Thu, 4 May 2006 19:24:07 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200605041833.k44IXbSW020147@repoman.freebsd.org> Message-ID: <20060504191933.P54242@maildrop.int.zabbadoz.net> References: <200605041833.k44IXbSW020147@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: Subject: Re: cvs commit: src/sys/net route.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 May 2006 19:25:14 -0000 On Thu, 4 May 2006, Bjoern A. Zeeb wrote: > bz 2006-05-04 18:33:37 UTC > > FreeBSD src repository > > Modified files: > sys/net route.c > Log: > In rtrequest and rtinit check for sa_len != 0 for the given > destination. These checks are needed so we do not install In addition to broken userland applications this will also affect in-kernel route setup and I expect one or the other to turn up being broken (there is a lot of rtr code in netinet6/* for nd for example). So in case you'll have problems setting up routes check that the caller correctly fills in all fields. gnn also suggested that we should catch those cases early in ioctl paths... -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT